--- Comment #2 from Andreas Gerstmayr <agerstmayr(a)redhat.com> ---
(In reply to Nathan Scott from comment #1)
[x] FROM instruction is first line
[?] FROM instruction is a fully-qualifies fedora registry/image:tag name
eg FROM registry.fedoraproject.org/fedora:latest
(pcp container using rawhide - should it use latest?)
[x] required labels present:
[?] architecture (usually x86_64)
(double check - missing? needed? may be fine without)
(should be an external list I guess - pcp(a)groups.io? pcp-masters?)
[x] optional labels present:
(double check - missing? wanted? fine without)
[x] each container image should provide only one
(exposing just pmproxy, which is good - someone will ask for pmcd later :)
(consider naming 'PMPROXY_PMSERIES_SERVERS' as 'REDIS_SERVERS' - in
they may be used for more than pmseries, e.g. full text search service :)
Heh, yeah ;)
[x] Help File Creation
[x] must have a help.1 or README.md
[?] must also be COPYed into the container, to live in the base directory
(check - is this missing? or handled via the 'COPY root /' line?)
Yep, this is handled by the COPY line.
There will be /README.md file inside the container.
Thanks a lot for the review!
You are receiving this mail because:
You are on the CC list for the bug.