[Bug 1822656] New: Container Review Request - PCP - Performance Co-Pilot

https://bugzilla.redhat.com/show_bug.cgi?id=1822656

            Bug ID: 1822656
           Summary: Container Review Request - PCP - Performance Co-Pilot
           Product: Fedora Container Images
           Version: rawhide
            Status: NEW
         Component: Container Review
          Assignee: nobody(a)fedoraproject.org
          Reporter: agerstmayr(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: container-review(a)lists.fedoraproject.org
  Target Milestone: ---
    Classification: Fedora



Container Build Info URL:
https://github.com/andreasgerstmayr/specs/tree/master/reviews/containers/pcp
Description: Performance Co-Pilot is a system performance analysis toolkit.
Fedora Account System Username: agerstmayr


-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1822656] Container Review Request - PCP - Performance Co-Pilot

https://bugzilla.redhat.com/show_bug.cgi?id=1822656

Nathan Scott <nathans(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody(a)fedoraproject.org    |nathans(a)redhat.com
              Flags|                            |fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1822656] Container Review Request - PCP - Performance Co-Pilot

https://bugzilla.redhat.com/show_bug.cgi?id=1822656

Nathan Scott <nathans(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Nathan Scott <nathans(a)redhat.com&gt; ---
Checklist is based on
https://docs.fedoraproject.org/en-US/containers/guidelines/guidelines/

Looks good, a couple of very minor questions below; if they're all OK this is
ready to go - Ack'd!


[x] Naming
    [x] matches main service it delivers
    [x] follows general fedora naming guidelines

[x] Dockerfile Creation
    [x] FROM instruction is first line
    [?] FROM instruction is a fully-qualifies fedora registry/image:tag name
        eg FROM registry.fedoraproject.org/fedora:latest

        (pcp container using rawhide - should it use latest?)

    [x] required labels present:
        [x] com.redhat.component
        [x] name
        [x] version (usually 0)
        [?] architecture (usually x86_64)

        (double check - missing?  needed?  may be fine without)

        [x] maintainer

        (should be an external list I guess - pcp(a)groups.io?  pcp-masters?)

        [x] run or usage
        [x] summary
    [x] optional labels present:
        [-] url
        [-] help

        (double check - missing?  wanted?  fine without)

    [x] labels defined in a single line
    [x] CMD or ENTRYPOINT present
    [x] Volumes used for persistent data
    [x] Volumes used for application data
    [x] Volumes listed in the help file
    [x] example run command contains volume with a persistent name
    [x] Volumes defined as narrowly as possible
    [x] Volumes in help file have full path of the volume
    [x] Volumes in help file show why its marked as a volume
    [x] Volumes in help file should describe space, permissions and performance
needs
    [x] readme may contain suggested additional volumes that aren’t made
mandatory

[x] Image Contents
    [x] contains no net new code (ie must use rpms)
    [x] each container image should provide only one "service"

        (exposing just pmproxy, which is good - someone will ask for pmcd later
:)
        (consider naming 'PMPROXY_PMSERIES_SERVERS' as 'REDIS_SERVERS' -
in
time,
         they may be used for more than pmseries, e.g. full text search service
:)

[x] Help File Creation
    [x] must have a help.1 or README.md
    [?] must also be COPYed into the container, to live in the base directory

        (check - is this missing?  or handled via the 'COPY root /' line?)

    [x] help file should contain
        [x] brief description of what service/software the image contains
        [x] the purpose it fulfills in a larger infrastructure
        [x] contain directions on how to configure the contained service
        [x] detail dependencies on any dependent services
        [x] detail what each of the VOLUMES is for, if any
        [x] explanation of each PORT the image listens on (protocol, purpose)
        [x] links to any external documentation if any exist
        [x] any special requirements of the container must be listed
        [x] information about major variants on how it can be built


-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1822656] Container Review Request - PCP - Performance Co-Pilot

https://bugzilla.redhat.com/show_bug.cgi?id=1822656



--- Comment #2 from Andreas Gerstmayr <agerstmayr(a)redhat.com&gt; ---
(In reply to Nathan Scott from comment #1)
>      [x] FROM instruction is first line
>      [?] FROM instruction is a fully-qualifies fedora registry/image:tag name
>          eg FROM registry.fedoraproject.org/fedora:latest
>  
>  	(pcp container using rawhide - should it use latest?) 
Done

>  
>      [x] required labels present:
>  	[?] architecture (usually x86_64)
>  
>  	(double check - missing?  needed?  may be fine without) 
Added.

>  
>  	[x] maintainer
>  
>  	(should be an external list I guess - pcp(a)groups.io?  pcp-masters?) 
Updated

>  
>      [x] optional labels present:
>          [-] url
>          [-] help
>  
>  	(double check - missing?  wanted?  fine without) 
Added

>      [x] each container image should provide only one
> "service"
>  
>  	(exposing just pmproxy, which is good - someone will ask for pmcd later :)
>  	(consider naming 'PMPROXY_PMSERIES_SERVERS' as 'REDIS_SERVERS' - in
> time,
>  	 they may be used for more than pmseries, e.g. full text search service :) 
Heh, yeah ;)
Updated.

>  
>  [x] Help File Creation
>      [x] must have a help.1 or README.md
>      [?] must also be COPYed into the container, to live in the base directory
>  
>  	(check - is this missing?  or handled via the 'COPY root /' line?) 
Yep, this is handled by the COPY line.
There will be /README.md file inside the container.


Thanks a lot for the review!


-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1822656] Container Review Request - PCP - Performance Co-Pilot

https://bugzilla.redhat.com/show_bug.cgi?id=1822656

Andreas Gerstmayr <agerstmayr(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Type|Bug                         |---




-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1822656] Container Review Request: PCP - Performance Co-Pilot

https://bugzilla.redhat.com/show_bug.cgi?id=1822656

Andreas Gerstmayr <agerstmayr(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Container Review Request -  |Container Review Request:
                   |PCP - Performance Co-Pilot  |PCP - Performance Co-Pilot




-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1822656] Container Review Request: pcp - Performance Co-Pilot

https://bugzilla.redhat.com/show_bug.cgi?id=1822656

Andreas Gerstmayr <agerstmayr(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Container Review Request:   |Container Review Request:
                   |PCP - Performance Co-Pilot  |pcp - Performance Co-Pilot




-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1822656] Container Review Request: pcp - Performance Co-Pilot

https://bugzilla.redhat.com/show_bug.cgi?id=1822656



--- Comment #3 from Gwyn Ciesla <gwync(a)protonmail.com&gt; ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/container/pcp


-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1822656] Container Review Request: pcp - Performance Co-Pilot

https://bugzilla.redhat.com/show_bug.cgi?id=1822656

Andreas Gerstmayr <agerstmayr(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |NEXTRELEASE
        Last Closed|                            |2020-04-15 18:48:19




-- 
You are receiving this mail because:
You are on the CC list for the bug.