https://bugzilla.redhat.com/show_bug.cgi?id=1421601
Honza Horak hhorak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(hhorak@redhat.com | |) |
--- Comment #9 from Honza Horak hhorak@redhat.com --- Sources updated: Dockerfile URL: https://hhorak.fedorapeople.org/ruby-docker/Dockerfile Other files URL: https://hhorak.fedorapeople.org/ruby-docker/
(In reply to Marek Skalický from comment #4)
- Few labels are missing: [1]
BZComponent, RUN or Usage, Help
- Version label should be set to 0 [2]
- help file missing [3]
All fixed now: ... ENV NAME=ruby \ VERSION=0 \ RELEASE=1 \ ARCH=x86_64
LABEL BZComponent="$NAME" \ Name="$FGC/$NAME" \ Version="$VERSION" \ Release="$RELEASE.$DISTTAG" \ Architecture="$ARCH" \ Usage="s2i build file:///your/app 25/ruby your-app" \ Help="help.1" ...
- Please use "LABEL MAINTAINER" instead of "MAINTAINER" build command (BTW
it is deprecated in latest docker releases)
Also fixed.
(In reply to Pavel Raiskup from comment #8)
- All the examples in guidelines tell about 'FROM: fedora:25', not 'FROM: 25'
It's not only FROM 25, it's FROM 25/s2i-base, since that is the name which the s2i-base will be available under.
- guidelines tell us to install software from RPMs provided by RPMs, but that statement should be probably relaxed: The Fedora Layered Image Build Service will reject images that are found to be built from sets of software not provided by Koji ....
Yeah, some starting scripts are fine, my interpretation is that we should not include big chunk of data or compile applications from source in Dockerfiles..
Vít Ondruch wrote:
Isn't this something what should be supported by OSBS or whatever is building the images?
This is not proper place to discuss this, feel free to bring this topic to cloud SIG, so the guidelines can be changed: https://fedoraproject.org/wiki/Container:Guidelines
container-review@lists.fedoraproject.org