codebase will be now hosted on pagure.io (https://pagure.io/copr/copr). We
would like to start working on this platform. Not that Github is bad but I
think that pagure.io will be good place as well.
Thanks for the dist-git patch !
There is an issue with naming, what does "dist-git" mean? Is that copr's
dist-git? Is that Fedora's dist-git? Is that Red Hat Internal dist-git?
Can each package be built from different dist-git instance? If not, why?
+ def get_srpm(self):
+ cmd = ['git', 'clone', self.task.distgit_clone_url, self.tmp_dest]
+ output, error = VM.run(cmd, dst_dir=self.tmp_dest, name=self.task.task_id)
+ if self.task.distgit_branch:
+ cmd = ['fedpkg', '--dist', self.task.distgit_branch, 'srpm']
+ cmd = ['fedpkg', 'srpm']
Please consider naming this Provider like FedoraDistGit, and rename
everything API related into Fedora namespace, because this is not generic
"dist-git". If we have it "renamed", this would be fine contribution ...
but otherwise we waste namespace in api without a way back, and forever --
DON'T RELEASE YET.
Internally (RHEL) we also have dist-git, and it would be really nice to have
this configurable so we can reuse this, or add RHELDistGit, too..
+ output, error = VM.run(cmd, dst_dir=self.tmp_dest, name=self.task.task_id, cwd=self.tmp_dest)
Please consider moving all this expensive tasks onto builder. That's the only
_secure_ way to add "SRPM providers" and it is the only scalable way (koji does
this right, we can possibly copy code from there - or at least study). Also,
VM != virtualization in this case, which is confusing.
Seriously, this is basically good code, but start doing reviews so people
involved can discuss design issues.
I want to highlight
Right now we have rawhide target and when new chroot (e.g. F26) we copy everything from rawhide to F26.
This RFE as for the reverse. I.e. there is no rawhide at all. Rawhide is named F26 and when there is branching of F26 we
add new chroot named F27.
I would love to hear your comments.
Miroslav Suchy, RHCA
Red Hat, Senior Software Engineer, #brno, #devexp, #fedora-buildsys
a quiz question...did you know what COPR actually stands for?
It stands for *Co*mmunity *Pr*ojects.
We have recently discovered this name (after formerly calling it Cool Other
Package Repositories) and we would like to share this cool discovery with
It might take some time for this new name to propagate everywhere it should.