Automatic rawhide rebuilds vs. src.fp.o Pull Requests

[Miro Hrončok]

I have several copr setup to automatically rebuild rawhide packages in various 
buildroots.

The source of the package is set to:

https://src.fedoraproject.org/rpms/<name>.git

And committish is set to master.

Yet when I made Pull Request on src.fp.o, Copr built that package.

On the builds tab, I see that Copr understands what a PR is, as it lists it 
separately as a special "directory".

See ":pr:11" at https://copr.fedorainfracloud.org/coprs/g/python/pypy36/builds/

It seems that the package is not available in the copr repo.

Could you help me understand this feature?

Can anyone build anything in my copr via this feature, but for obvious reasons, 
the builds are not added to the repo?

-- 
Miro Hrončok
--
Phone: [phone]
IRC: mhroncok

[Pavel Raiskup]

On Monday, May 27, 2019 5:42:01 PM CEST Miro Hrončok wrote:
>  It seems that the package is not available in the copr repo. 
It is not in the main copr repo (directory), but in separate one
(dedicated to a concrete PR).

>  Could you help me understand this feature? 
It was designed so you can 'dnf copr enable
<owner>/<project>:pr:<id>'
instead.  It's though not something people should trust automatically..

>  Can anyone build anything in my copr via this feature, but for
> obvious
>  reasons, the builds are not added to the repo? 
Right, anyone who is able to submit PR is able to build within your
project, though in separate directory so the production repo isn't affected.

Pavel

[Miro Hrončok]

On 28. 05. 19 6:11, Pavel Raiskup wrote:
>  On Monday, May 27, 2019 5:42:01 PM CEST Miro Hrončok wrote:
> > It seems that the package is not available in the copr repo.
>  
>  It is not in the main copr repo (directory), but in separate one
>  (dedicated to a concrete PR).
>  
> > Could you help me understand this feature?
>  
>  It was designed so you can 'dnf copr enable
> <owner>/<project>:pr:<id>'
>  instead.  It's though not something people should trust automatically..
>  
> > Can anyone build anything in my copr via this feature, but for obvious
> > reasons, the builds are not added to the repo?
>  
>  Right, anyone who is able to submit PR is able to build within your
>  project, though in separate directory so the production repo isn't affected. 
Thanks. I think I understand this now.
I'm glad this is not "poisoning" the repository.

Either way however, I'm afraid of quota issues (for the record, I've just added 
~2700 such integrations).

Is there a way to opt-out?

(I'm also curious about the UX of the builds page once there are hundreds of PRs.)

-- 
Miro Hrončok
--
Phone: [phone]
IRC: mhroncok

[Pavel Raiskup]

On Tuesday, May 28, 2019 11:58:20 AM CEST Miro Hrončok wrote:
>  On 28. 05. 19 6:11, Pavel Raiskup wrote:
>  > On Monday, May 27, 2019 5:42:01 PM CEST Miro Hrončok wrote:
>  >> It seems that the package is not available in the copr repo.
>  > 
>  > It is not in the main copr repo (directory), but in separate one
>  > (dedicated to a concrete PR).
>  > 
>  >> Could you help me understand this feature?
>  > 
>  > It was designed so you can 'dnf copr enable
> <owner>/<project>:pr:<id>'
>  > instead.  It's though not something people should trust automatically..
>  > 
>  >> Can anyone build anything in my copr via this feature, but for obvious
>  >> reasons, the builds are not added to the repo?
>  > 
>  > Right, anyone who is able to submit PR is able to build within your
>  > project, though in separate directory so the production repo isn't affected.
>
>  Thanks. I think I understand this now.  I'm glad this is not "poisoning"
>  the repository.
>
>  Either way however, I'm afraid of quota issues (for the record, I've
>  just added ~2700 such integrations). 
You probably mean ~2700 package "source definitions", so they are built
from fedora dist-git.  The "Integration" tab doesn't seem to be filled.

>  Is there a way to opt-out? 
Uncheck the 'Auto-rebuild the package? (i.e. every commit or new tag)'
checkbox.  That will though both disable pull-request->build support and
commit->build support.  Having a separate checkbox for PRs and for pushes
would be a valid RFE, FWIW.

>  (I'm also curious about the UX of the builds page once there are
>  hundreds of PRs.) 
Yes, the whole concept is in a rather early stage, speaking very carefully
(I do not even have to consider such "specific" projects as your one is).

Pavel

[Miro Hrončok]

On 28. 05. 19 6:11, Pavel Raiskup wrote:
>  On Monday, May 27, 2019 5:42:01 PM CEST Miro Hrončok wrote:
> > It seems that the package is not available in the copr repo.
>  It is not in the main copr repo (directory), but in separate one
>  (dedicated to a concrete PR). 
It seems to me that the directories are all called
<copr_name>:pr:<pr_number>.

What happens when 2 or more PRs to different repos have the same number?

https://copr.fedorainfracloud.org/coprs/g/python/python3.8/builds/?dirnam...

Does the second build "see" the previous one?

It seems that namesapcing by package name is missing. Is that a bug or an 
intentionally made decision?

-- 
Miro Hrončok
--
Phone: [phone]
IRC: mhroncok

[Pavel Raiskup]

On Tuesday, May 28, 2019 8:07:54 PM CEST Miro Hrončok wrote:
>  On 28. 05. 19 6:11, Pavel Raiskup wrote:
>  > On Monday, May 27, 2019 5:42:01 PM CEST Miro Hrončok wrote:
>  >> It seems that the package is not available in the copr repo.
>  > It is not in the main copr repo (directory), but in separate one
>  > (dedicated to a concrete PR).
>
>  It seems to me that the directories are all called
>  <copr_name>:pr:<pr_number>.
>
>  What happens when 2 or more PRs to different repos have the same number?
>
>
> https://copr.fedorainfracloud.org/coprs/g/python/python3.8/builds/?dirnam...
>  
>  Does the second build "see" the previous one? 
Unfortunately, yes.

>  It seems that namesapcing by package name is missing. Is that a bug
> or
>  an intentionally made decision? 
It is not yet resolved design issue.  And I guess you are the first person
building multiple pagure projects into one copr repo.

Pavel

[Pavel Raiskup]

On Tuesday, May 28, 2019 10:22:34 PM CEST Pavel Raiskup wrote:
>  On Tuesday, May 28, 2019 8:07:54 PM CEST Miro Hrončok wrote:
>  > What happens when 2 or more PRs to different repos have the same number?
>  > ..
>  > Does the second build "see" the previous one?
>  
>  Unfortunately, yes. 
I was wrong here, sorry.  The '*:pr:* repo is not in list of repositories for
the second build.

Pavel