disable networking in Copr by default

[Pavel Raiskup]

Just to be more pedantic and probably bit more secure, what about making
networking in copr opt-in (at least for new projects)?

If build of my package used internet arbitrarily, I would be warned very
early..

Also, in Koji we also do not have networking, so we can faster teach
(future) Fedora packagers.

Thanks for considering,
Pavel

[Greg Sheremeta]

+1.

----- Original Message -----
>  From: "Pavel Raiskup" <praiskup(a)redhat.com&gt;
>  To: "copr" <copr-devel(a)lists.fedorahosted.org&gt;
>  Sent: Monday, May 11, 2015 9:21:33 AM
>  Subject: disable networking in Copr by default
>  
>  Just to be more pedantic and probably bit more secure, what about making
>  networking in copr opt-in (at least for new projects)?
>  
>  If build of my package used internet arbitrarily, I would be warned very
>  early..
>  
>  Also, in Koji we also do not have networking, so we can faster teach
>  (future) Fedora packagers.
>  
>  Thanks for considering,
>  Pavel
>  
>  _______________________________________________
>  copr-devel mailing list
>  copr-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/copr-devel
>

[PATCH][frontend]disableinternetconnectionbydefault

[Pavel Raiskup]

Users are always able to turn the internet connection ON, but only
when *necessary*.  This should be good default safety belt for
unintentional downloads during package-build which could
compromise build results.  This should affect only newly created
projects.
---
 frontend/coprs_frontend/coprs/forms.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/coprs_frontend/coprs/forms.py
b/frontend/coprs_frontend/coprs/forms.py
index 11bcbc4..b42f030 100644
--- a/frontend/coprs_frontend/coprs/forms.py
+++ b/frontend/coprs_frontend/coprs/forms.py
@@ -210,7 +210,7 @@ class CoprFormFactory(object):
                 filters=[StringListFilter()])
 
             disable_createrepo = wtforms.BooleanField(default=False)
-            build_enable_net = wtforms.BooleanField(default=True)
+            build_enable_net = wtforms.BooleanField(default=False)
 
             @property
             def selected_chroots(self):
-- 
2.5.0

[PATCH][frontend]disableinternetconnectionbydefault

[Miroslav Suchý]

Dne 7.1.2016 v 12:30 Pavel Raiskup napsal(a):
>  Users are always able to turn the internet connection ON, but only
>  when *necessary*.  This should be good default safety belt for
>  unintentional downloads during package-build which could
>  compromise build results.  This should affect only newly created
>  projects. 
Pushed as
* d0dcf9f (HEAD -> master, origin/master, origin/HEAD) disable internet connection by
default

Thank you.

-- 
Miroslav Suchy, RHCA
Red Hat, Senior Software Engineer, #brno, #devexp, #fedora-buildsys