Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : bkabrda-workspace
commit 7869d405748c3beeb75230977cbfa61a90a51af5 Author: Bohuslav Kabrda bkabrda@redhat.com Date: Wed Nov 28 18:36:55 2012 +0100
Fix displaying the permissions table
coprs_frontend/coprs/templates/coprs/detail.html | 2 +- .../tests/test_views/test_coprs_ns/test_general.py | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/coprs_frontend/coprs/templates/coprs/detail.html b/coprs_frontend/coprs/templates/coprs/detail.html index 7f6a977..fb94430 100644 --- a/coprs_frontend/coprs/templates/coprs/detail.html +++ b/coprs_frontend/coprs/templates/coprs/detail.html @@ -22,7 +22,7 @@ </ul> {% endif %} <h3>Permissions</h3> - {% if g.user.id == copr.owner_id %} + {% if g.user.id == copr.owner_id or not g.user %} {{ permissions_table(permissions, copr, None) }} {% else %} {{ permissions_table(permissions, copr, permission_applier_form) }} diff --git a/coprs_frontend/tests/test_views/test_coprs_ns/test_general.py b/coprs_frontend/tests/test_views/test_coprs_ns/test_general.py index 57c3d7b..6a318bd 100644 --- a/coprs_frontend/tests/test_views/test_coprs_ns/test_general.py +++ b/coprs_frontend/tests/test_views/test_coprs_ns/test_general.py @@ -109,7 +109,11 @@ class TestCoprDetail(CoprsTestCase): r = self.tc.get('/coprs/detail/{0}/{1}/'.format(self.u1.name, self.c1.name)) assert r.data.count('<tr class=build') == 2
- def test_copr_detail_contains_permissions(self, f_users, f_coprs, f_copr_permissions): + def test_copr_detail_anonymous_doesnt_contain_permissions_table_when_no_permissions(self, f_users, f_coprs, f_copr_permissions): + r = self.tc.get('/coprs/detail/{0}/{1}/'.format(self.u1.name, self.c1.name)) + assert '<table class=permissions' not in r.data + + def test_copr_detail_contains_permissions_table(self, f_users, f_coprs, f_copr_permissions): r = self.tc.get('/coprs/detail/{0}/{1}/'.format(self.u2.name, self.c3.name)) assert '<table class=permissions' in r.data assert '<tr><td>{0}'.format(self.u3.name) in r.data
copr-devel@lists.fedorahosted.org