On Fri, 2010-08-27 at 17:05 +0200, Nikola Pajkovsky wrote:
Signed-off-by: Nikola Pajkovsky npajkovs@redhat.com
src/applet/Applet.cpp | 18 +++--- src/applet/CCApplet.cpp | 154 +++++++++++++++++++++++++---------------------- src/applet/CCApplet.h | 110 +++++++++++++++++---------------- 3 files changed, 146 insertions(+), 136 deletions(-)
Looks ok to me.
+/*
- What is better name for struct?
- typedef struct _applet {
- ...
- } applet_t;
- or
- */
I don't see any reason to use "struct _applet". _names with underscores are reserved for compiler and libc, it's better to avoid them.
I've seen this style:
typedef struct foo { ... } foo;
which makes both "foo" and "struct foo" the same (a-la C++). Other common practice is to add _t suffix to names which refer to types:
typedef struct foo { ... } foo_t;
I like both of these styles.