[PATCH] applet: Remove the automatic crash reporting message dialog

[Bastien Nocera]

See https://github.com/abrt/gnome-abrt/issues/74#issuecomment-68704587
---
 src/applet/applet.c | 63 -----------------------------------------------------
 1 file changed, 63 deletions(-)

diff --git a/src/applet/applet.c b/src/applet/applet.c
index 4f5d587..4d2949c 100644
--- a/src/applet/applet.c
+++ b/src/applet/applet.c
@@ -91,27 +91,6 @@ static bool is_autoreporting_enabled(void)
     return ret;
 }

-static bool is_ureport_auth_enabled(void)
-{
-    bool success, auth_enabled;
-    map_string_t *settings = new_map_string();
-    char *ureport_conf_path = concat_path_file(LIBREPORT_PLUGINS_CONF_DIR, "ureport.conf");
-
-    success = load_conf_file(ureport_conf_path, settings, /*skipKeysWithoutValue*/false);
-    if (success)
-    {
-        const char *value = get_map_string_item_or_NULL(settings, "SSLClientAuth");
-        auth_enabled = (value && value[0] != '\0');
-    }
-    else
-        auth_enabled = true; /* assume it is, do not claim the reporting is anonymous */
-
-    free(ureport_conf_path);
-    free_map_string(settings);
-
-    return auth_enabled;
-}
-
 static const char *get_autoreport_event_name(void)
 {
     load_user_settings("abrt-applet");
@@ -119,45 +98,6 @@ static const char *get_autoreport_event_name(void)
     return configured ? configured : g_settings_autoreporting_event;
 }

-static void ask_start_autoreporting()
-{
-    struct strbuf *question = strbuf_new();
-    question = strbuf_append_str(question,
-         _("The report which will be sent does not contain any security sensitive data. "
-           "Therefore it is not necessary to bother you next time and require any further action by you. \n"));
-
-    if (is_ureport_auth_enabled())
-    {
-        question = strbuf_append_str(question,
-            _("Do you want to enable automatically submitted crash reports?"));
-    }
-    else
-    {
-        question = strbuf_append_str(question,
-            _("Do you want to enable automatically submitted anonymous crash reports?"));
-    }
-
-    /* The "Yes" response will be saved even if user don't check the
-     * "Don't ask me again" box.
-     */
-    const int ret = run_ask_yes_no_save_result_dialog("AutoreportingEnabled", question->buf,
-       /*parent wnd */ NULL);
-    strbuf_free(question);
-
-    load_user_settings("abrt-applet");
-
-    /* Don't forget:
-     *
-     * The "Yes" response will be saved even if user don't check the
-     * "Don't ask me again" box.
-     */
-    if (ret != 0)
-        set_user_setting("AutoreportingEnabled", "yes");
-
-    /* must be called immediately, otherwise the data could be lost in case of crash */
-    save_user_settings();
-}
-
 static bool is_shortened_reporting_enabled()
 {
     return get_configured_bool_or_default("ShortenedReporting", g_settings_shortenedreporting);
@@ -597,9 +537,6 @@ static void action_report(NotifyNotification *notification, gchar *action, gpoin
         }
         else
         {
-            if (pi->foreign == false && strcmp(A_REPORT_AUTOREPORT, action) == 0)
-                ask_start_autoreporting();
-
             /* if shortened reporting is configured don't start reporting process
              * when problem is unknown (just show notification) */
             run_event_async(pi, get_autoreport_event_name(),

[Jakub Filak]

Pushed. Thanks!