- an event command line lead by an empty line is run for every event - this behaviour make some peopel confused thus we notify them from now
Signed-off-by: Jakub Filak jfilak@redhat.com --- src/lib/run_event.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/src/lib/run_event.c b/src/lib/run_event.c index bc04c5e..04cf1a1 100644 --- a/src/lib/run_event.c +++ b/src/lib/run_event.c @@ -126,17 +126,23 @@ static GList *load_rule_list(GList *rule_list, return rule_list; }
+ /* Used only for better warning message */ + int line_counter = 0; /* Read and remember rules */ char *next_line = xmalloc_fgetline(conffile); while (next_line) { /* Read and concatenate all lines in a rule */ char *line = next_line; + ++line_counter; + while (1) { next_line = xmalloc_fgetline(conffile); if (!next_line || !isblank(next_line[0])) break; + + ++line_counter; char *old_line = line; line = xasprintf("%s\n%s", line, next_line); free(old_line); @@ -207,6 +213,9 @@ static GList *load_rule_list(GList *rule_list, p = skip_whitespace(end_word); } /* end of word loop */
+ if (cur_rule->conditions == NULL) + log("%s:%d: warning: command without conditions -> this command will be executed for all events", conf_file_name, line_counter); + VERB1 log("Adding '%s'", p); cur_rule->command = xstrdup(p);