Re: [PATCH] track#552 : reporter-ureport : allows to enable/disable SSL certificate checking

[Nikola Pajkovsky]

Jakub Filak <jfilak(a)redhat.com&gt; writes:

>  Signed-off-by: Jakub Filak <jfilak(a)redhat.com&gt;
>  ---
>   src/include/internal_libreport.h  |    3 --
>   src/lib/Makefile.am               |    3 +-
>   src/lib/json.c                    |   15 +++++++-----
>   src/lib/ureport.h                 |   46 +++++++++++++++++++++++++++++++++++++
>   src/plugins/report_uReport.xml.in |    5 ++++
>   src/plugins/ureport.c             |   23 ++++++++----------
>   6 files changed, 72 insertions(+), 23 deletions(-)
>   create mode 100644 src/lib/ureport.h 
>  +
>  +/*
>  + * uReport server configuration
>  + */
>  +struct ureport_server_config
>  +{
>  +    const char *s_url; ///< Web service URL
>  +    bool b_ssl_verify; ///< Verify HOST and PEER certificates
>  +}; 
we are not in c++ so we don't need any superfluous prefix notation

>   
>       struct ureport_server_config config = {
>  -        .url = "https://retrace.fedoraproject.org/faf/reports/new/",
>  +        .s_url = "https://retrace.fedoraproject.org/faf/reports/new/",
>  +        .b_ssl_verify = true,
>       };
>   
>       const char *dump_dir_path = ".";
>       struct options program_options[] = {
>           OPT__VERBOSE(&g_verbose),
>           OPT__DUMP_DIR(&dump_dir_path),
>  -        OPT_STRING('u', "url", &config.url, "URL",
> _("Specify url")),
>  +        OPT_STRING('u', "url", &config.s_url, "URL",
> _("Specify url")),
>           OPT_END(),
>       }; 
missing OPT_BOOL opt for disabling ssl_verify. take a look at
abrt/src/plugins/abrt-retrace-client.c

OPT_BOOL('k', "insecure", NULL,
                 _("allow insecure connection to retrace server")),

-- 
Nikola