On Mon, 2010-10-04 at 15:03 +0200, Jiri Moskovcak wrote:
On 10/04/2010 10:11 AM, Nikola Pajkovsky wrote:
> On 10/01/2010 04:00 PM, Jiri Moskovcak wrote:
>> On 09/29/2010 01:17 PM, Nikola Pajkovsky wrote:
>>> Signed-off-by: Nikola Pajkovsky<npajkovs(a)redhat.com>
>>> ---
>>> src/daemon/Daemon.cpp | 65
+++++++++++++++++++++++++-----------------------
>>> 1 files changed, 34 insertions(+), 31 deletions(-)
>>>
>>> diff --git a/src/daemon/Daemon.cpp b/src/daemon/Daemon.cpp
>>> index 8ab9991..5a4db14 100644
>>> --- a/src/daemon/Daemon.cpp
>>> +++ b/src/daemon/Daemon.cpp
>>> @@ -34,6 +34,7 @@
>>> #include "CrashWatcher.h"
>>> #include "Daemon.h"
>>> #include "rpm.h"
>>> +#include "parse_options.h"
>>>
>>> using namespace std;
>>>
>>> @@ -85,6 +86,10 @@ using namespace std;
>>> * Both are sent as unicast to last client set by
set_client_name(name).
>>> * If set_client_name(NULL) was done, they are not sent.
>>> */
>>> +static const char * const abrtd_usage[] = {
>> - does it have to be static?
>
> I don't want to accidentally collide with others module, also it says it will be
used
> only here and there is no *extern*
static is needed to not expose the name as an external reference.
The good practice is to keep everything static except function and data
object names which must be visible by other modules.
--
vda