On Tuesday 11 of December 2012 17:00:24 Denys Vlasenko wrote:

> On 12/11/2012 01:45 PM, Jakub Filak wrote:

> > - related to trac#916

>

> Looks good to me.

>

> > --- a/src/gtk-helpers/internal_libreport_gtk.h

> > +++ b/src/gtk-helpers/internal_libreport_gtk.h

> > @@ -95,6 +95,26 @@ struct url_token

> > #define find_url_tokens libreport_find_url_tokens

> > GList *find_url_tokens(const char *line);

> >

> > +#define run_ask_yes_no_yesforever_dialog libreport_run_ask_yes_no_yesforever_dialog

> > +int run_ask_yes_no_yesforever_dialog(const char *key, const char *message, GtkWindow *parent);

>

> The function name needs to be more descriptive.

> I don't have a really good proposal, though...

>

> "run_ask_yes_no_dialog_with_checkbox" maybe?

>

>

libreport uses ask_yes_no_yesforever at many places and abrt too

Should I change the string everywhere?