On 09/01/2010 02:43 PM, Nikola Pajkovsky wrote:
On 09/01/2010 02:05 PM, Jiri Moskovcak wrote:
> On 09/01/2010 01:55 PM, Nikola Pajkovsky wrote:
>> On 09/01/2010 12:26 PM, Denys Vlasenko wrote:
>>> On Wed, 2010-09-01 at 11:46 +0200, Nikola Pajkovsky wrote:
>>>> Signed-off-by: Nikola Pajkovsky<npajkovs(a)redhat.com>
>>>> ---
>>>> lib/utils/DebugDump.cpp | 43
++++++++++++++++++++++---------------------
>>>> 1 files changed, 22 insertions(+), 21 deletions(-)
>>>>
>>>> diff --git a/lib/utils/DebugDump.cpp b/lib/utils/DebugDump.cpp
>>>> index 8987b43..37e21c7 100644
>>>> --- a/lib/utils/DebugDump.cpp
>>>> +++ b/lib/utils/DebugDump.cpp
>>>> @@ -34,7 +34,8 @@ static bool isdigit_str(const char *str)
>>>> return true;
>>>> }
>>>>
>>>> -static char* RemoveBackSlashes(const char *pDir)
>>>> +// doesn't it only slash?
>>>> +static char* rm_backslashes(const char *pDir)
>>>
>>> You are right. It removes slashes, not backslashes.
>>> I propose rm_trailing_slashes
>>>
>>
>> Sounds good to me.
>>
>>>> -static bool ExistFileDir(const char *pPath)
>>>> +static bool exist_file_dir(const char *pPath)
>>>
>>> Ok.
>>>
>>>> -static char *LoadTextFile(const char *path);
>>>> +static char *loadtxt_file(const char *path);
>>>
>>> Why not load_text_file?
>>>
>>
>> we have dd_loadtxt so I wanted to have in same form, but I don't
>> have any problem with your proposal.
>>
>
> so the best would be to unify it and rename dd_loadtxt do dd_load_text...
>
this is not only dd_load_txt, but also dd_savetxt to dd_save_text(a little more work).
I have no problem with loadtxt_file, but if you have another opinion
I'm all ears[hate democracy:)]
by "unify it" I of course meant ALL of it... so the names will be:
dd_{load,save}_{bin,text}_file
>
>>>> -static bool GetAndSetLock(const char* pLockFile, const char* pPID)
>>>> +static bool get_and_set_lock(const char* pLockFile, const char* pPID)
>>>
>>> ok
>>>
>>>> -static bool DeleteFileDir(const char *pDir)
>>>> +static bool delete_file_dir(const char *pDir)
>>>
>>> Ok
>>>
>>>> -static bool SaveBinaryFile(const char *pPath, const char* pData,
unsigned size, uid_t uid, gid_t gid)
>>>> +static bool savebin_file(const char *pPath, const char* pData, unsigned
size, uid_t uid, gid_t gid)
>>>
>>> I propose save_binary_file
>>>
>>
>> ditto
_______________________________________________
Crash-catcher mailing list
Crash-catcher(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/crash-catcher