On 06/12/2013 10:56 AM, Jakub Filak wrote:
The code lives in system-config-abrt branch.
Thank you for your consideration on this matter
Jakub
At first glance:
1. the apply button should have some margin (At least in G3 it doesn't have any) 2. s/crash/problem 3. s/by click/by clicking/
Jirka
----- Original Message ----- From: "Jakub Filak" jfilak@redhat.com To: "Crash-Catcher" crash-catcher@lists.fedorahosted.org Cc: "Jakub Filak" jfilak@redhat.com Sent: Monday, May 13, 2013 2:24:10 PM Subject: [ABRT PATCH 4/4] applet: stop saving configuration at exit
And overriding changes made by user in desktop session.
Related to #594
Signed-off-by: Jakub Filak jfilak@redhat.com
src/applet/applet.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/applet/applet.c b/src/applet/applet.c index f851c8d..c7232bd 100644 --- a/src/applet/applet.c +++ b/src/applet/applet.c @@ -1524,7 +1524,16 @@ next: if (notify_is_initted()) notify_uninit();
- save_user_settings();
/* It does not make much sense to save settings at exit and after
* introduction of system-config-abrt it is wrong to do that. abrt-applet
* is long-running application and user can modify the configuration files
* while abrt-applet run. Thus, saving configuration at desktop session
* exit would make someone's life really hard.
*
* abrt-applet saves configuration immediately after user input.
*
* save_user_settings();
*/ g_dbus_connection_signal_unsubscribe(g_system_bus, signal_ret); g_object_unref(g_system_bus);