I tested it and it works well. Feel free to push it to the repository.
Two comments:
1) The program returns 0 and creates the uuid file even when eu-unstrip
fails. This is consistent with current CCpp plugin behaviour, but we
might want to change that (probably later, when it becomes clear how the
communication will be handled) as programs should behave differently.
$ rm coredump
$ touch coredump
$ ./abrt-action-analyze-c
eu-unstrip: cannot read ELF core file: not a valid ELF file
$ echo $?
0
$ cat uuid
da39a3ee5e6b4b0d3255bfef95601890afd80709
2) Jirka mentioned that the programs should be localized. This can
probably be done later, together with the rest of programs.
Thanks,
Karel
On 10/13/2010 01:31 PM, Denys Vlasenko wrote:
On Wed, 2010-10-13 at 13:26 +0200, Denys Vlasenko wrote:
> On Wed, 2010-10-13 at 12:15 +0200, Denys Vlasenko wrote:
>> This patch splits off uuid generation for CCpp
>> to a separate program:
>>
>> # abrt-action-analyze-c --help
>> Usage: abrt-action-analyze-c [-v] -d DIR
>>
>> Calculates and saves UUID
>>
>> -v, --verbose be verbose
>> -d DIR Crash dump directory
>>
>> Run tested.
>>
>> Thus, now entire cycle of coredump processing/reporting
>> consists of external programs:
>>
>> abrt-action-analyze-c
>> abrt-action-save-package-data
>> abrt-action-install-debuginfo
>> abrt-action-generate-backtrace
>> abrt-action-bugzilla
>>
>> Please review.
>
> Found a bug on python side, here is an updated patch.
Gosh, I sent an old one again. THIS is the real updated one.