Re: [PATCH] report-cli rework

[Jakub Filak]

On Tuesday 08 of January 2013 12:48:04 Denys Vlasenko wrote:
> >    if (config->ec_sending_sensitive_data)
> >    {
> >        /* We assume this event is a reporter */
> >
> > This assumption is invalid at least for report_Bugzilla event.
>
> report_Bugzilla isn't a reporter?

Sure, it is. But report_Bugzilla's ec_sending_sensitive_data is FALSE.
> > list_free_with_free(list_events);
> >
> > I'd say that list_free_with_free() is obsolete. The g_list_free_full() is the function which should be used here.
>
> g_list_free_full() is not available in older versions of Glib.

Argh, I forgot that we have keep libreport buildable on RHEL6.

Shouldn't we replace all occurrences of g_list_free_full() by list_free_with_free() in libreport/ABRT?