[ABRT EL6 PATCH 1/3] fix problem occurrence counter updating algorithm

[Jiri Moskovcak]

From: Jakub Filak

- closes trac#878

Signed-off-by: Jakub Filak 
---
 src/daemon/abrtd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/daemon/abrtd.c b/src/daemon/abrtd.c
index 6e73cb3..85f39fb 100644
--- a/src/daemon/abrtd.c
+++ b/src/daemon/abrtd.c
@@ -400,14 +400,15 @@ static gboolean handle_event_output_cb(GIOChannel *gio, GIOCondition condition,
         {
             log("'post-create' on '%s' killed by signal %d",
                             state->dirname, WTERMSIG(status));
+            goto delete_bad_dir;
         }
         /* else: it is WIFEXITED(status) */
         else if (!state->dup_of_dir)
         {
             log("'post-create' on '%s' exited with %d",
                             state->dirname, WEXITSTATUS(status));
+            goto delete_bad_dir;
         }
-        goto delete_bad_dir;
     }

char *work_dir = state->dup_of_dir ? state->dup_of_dir : state->dirname;

[ABRT EL6 PATCH 2/3] use last_occurrence with --since

[Jiri Moskovcak]

closes #645

Signed-off-by: Jiri Moskovcak 
Signed-off-by: Richard Marko 
---
 src/lib/problem_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/problem_api.c b/src/lib/problem_api.c
index b7dad47..d940767 100644
--- a/src/lib/problem_api.c
+++ b/src/lib/problem_api.c
@@ -174,7 +174,7 @@ GList *get_problem_dirs_for_element_in_time(uid_t uid,
     };

const struct problem_condition timec = {
-        .field_name = FILENAME_TIME,
+        .field_name = FILENAME_LAST_OCCURRENCE,
         .args = &interval,
         .evaluate = time_interval_problem_condition
     };

[ABRT EL6 PATCH 3/3] console notification shouldn't ask confirmation - closes #652

[Jiri Moskovcak]

Signed-off-by: Jiri Moskovcak 
Signed-off-by: Jakub Filak 
---
 src/cli/abrt-console-notification.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cli/abrt-console-notification.sh b/src/cli/abrt-console-notification.sh
index 4082909..8e92d10 100755
--- a/src/cli/abrt-console-notification.sh
+++ b/src/cli/abrt-console-notification.sh
@@ -15,7 +15,7 @@ fi
 # always update the lastnotification
 if [ -f "$TMPPATH" ]; then
     date +%s > "$TMPPATH"
-    mv "$TMPPATH" "$SINCEFILE"
+    mv -f "$TMPPATH" "$SINCEFILE"
 fi

abrt-cli status --since="$SINCE" 2> /dev/null

[Jakub Filak]

Pushed. Thanks!

On Monday 13 of May 2013 14:48:09 Jiri Moskovcak wrote:
> From: Jakub Filak
> closes trac#878
> Signed-off-by: Jakub Filak
>
> src/daemon/abrtd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/daemon/abrtd.c b/src/daemon/abrtd.c
> index 6e73cb3..85f39fb 100644
> --- a/src/daemon/abrtd.c
> +++ b/src/daemon/abrtd.c
> @@ -400,14 +400,15 @@ static gboolean handle_event_output_cb(GIOChannel
> *gio, GIOCondition condition, {
>              log("'post-create' on '%s' killed by signal %d",
>                              state->dirname, WTERMSIG(status));
>        goto delete_bad_dir;
>    }
>    /* else: it is WIFEXITED(status) */
>    else if (!state->dup_of_dir)
>    {
>        log("'post-create' on '%s' exited with %d",
>                        state->dirname, WEXITSTATUS(status));
>        goto delete_bad_dir;
>    }
>    goto delete_bad_dir;
>
> }
>
> char *work_dir = state->dup_of_dir ? state->dup_of_dir :
>
> state->dirname;