[Crash-catcher] bugzilla report always crashed

[Zhu, Peter J]

Hi,

I used abrt-1.0.6. But it always crashed as it execute add_attachments. The original
xml-rpc parameter is
   s{s:s,s:s,s:s,s:s}
   bug_id_str.
   "description", ("File: " + itemname).c_str(),
   "filename", itemname.c_str(),
   "contenttype", "text/plain",
   "data", encoded64

I tried to modify with many ways like adding datasize
  s{s:s,s:s,s:s,s:s,s:i}
   bug_id_str.
   "description", ("File: " + itemname).c_str(),
   "filename", itemname.c_str(),
   "contenttype", "text/plain",
   "data", encoded64
   "datasize", strlen(encoded64)

   or adding field of bug_id
   {s:s,s:s,s:s,s:s,s:s,s:i}
   "bug_id", bug_id_str.
   "description", ("File: " + itemname).c_str(),
   "filename", itemname.c_str(),
   "contenttype", "text/plain",
   "data", encoded64

But I always got same crash with signal 6(abort). Any idea?

Thanks,
Peter

[Nikola Pajkovsky]

Dne 14.2.2010 20:23, Zhu, Peter J napsal(a):
>  Hi,
>
>  I used abrt-1.0.6. But it always crashed as it execute 
>  add_attachments. The original xml-rpc parameter is
>
>     s{s:s,s:s,s:s,s:s}
>
>     bug_id_str.
>
>     "description", ("File: " + itemname).c_str(),
>
>     "filename", itemname.c_str(),
>
>     "contenttype", "text/plain",
>
>     "data", encoded64
>
>  I tried to modify with many ways like adding datasize
>
>    s{s:s,s:s,s:s,s:s,s:i}
>
>     bug_id_str.
>
>     "description", ("File: " + itemname).c_str(),
>
>     "filename", itemname.c_str(),
>
>     "contenttype", "text/plain",
>
>     "data", encoded64
>
>     "datasize", strlen(encoded64)
>
>     or adding field of bug_id
>
>     {s:s,s:s,s:s,s:s,s:s,s:i}
>
>     "bug_id", bug_id_str.
>
>     "description", ("File: " + itemname).c_str(),
>
>     "filename", itemname.c_str(),
>
>     "contenttype", "text/plain",
>
>     "data", encoded64
>
>
>  But I always got same crash with signal 6(abort). Any idea?
>
>  Thanks,
>
>  Peter
>  
Hello,

could you send me backtrace and rpm -q abrt? Try to update to the newest 
abrt-1.0.7

Nikola

[Zhu, Peter J]

Hi,
> Hello,
>
> could you send me backtrace and rpm -q abrt? Try to update to the newest abrt-1.0.7
Please see http://pastebin.com/md85ca75 for backtrace, it crashed as it tried to remove
reference to result. 

Where can I download 1.0.7?  

Thanks,
Peter

[Nikola Pajkovsky]

Dne 15.2.2010 19:12, Zhu, Peter J napsal(a):
>  Hi,
>     
> > Hello,
> >
> > could you send me backtrace and rpm -q abrt? Try to update to the newest abrt-1.0.7
> >      
>  Please see http://pastebin.com/md85ca75 for backtrace, it crashed as it tried to remove
> reference to result.
>
>  Where can I download 1.0.7?
>
>  Thanks,
>  Peter
>
>      
yum --enablerepo=updates-testing update abrt

-- 
Nikola

[Zhu, Peter J]

Hi
>  -----Original Message-----
>  From: Nikola Pajkovsky [mailto:[e-mail]]
>  Sent: Tuesday, February 16, 2010 2:37 AM
>  To: Zhu, Peter J
>  Cc: crash-catcher(a)lists.fedorahosted.org
>  Subject: Re: [Crash-catcher] bugzilla report always crashed
>  
>  Dne 15.2.2010 19:12, Zhu, Peter J napsal(a):
>  > Hi,
>  >
>  >> Hello,
>  >>
>  >> could you send me backtrace and rpm -q abrt? Try to update to the newest
>  abrt-1.0.7
>  >>
>  > Please see http://pastebin.com/md85ca75 for backtrace, it crashed as it
>  tried to remove reference to result.
>  >
>  > Where can I download 1.0.7?
>  >
>  > Thanks,
>  > Peter
>  >
>  >
>  yum --enablerepo=updates-testing update abrt
>   
Are you sure it works? I double checked and there is no abrt in updates-testing repo.

Peter

[Nikola Pajkovsky]

Dne 16.2.2010 05:37, Zhu, Peter J napsal(a):
>  Hi
>     
> > -----Original Message-----
> > From: Nikola Pajkovsky [mailto:[e-mail]]
> > Sent: Tuesday, February 16, 2010 2:37 AM
> > To: Zhu, Peter J
> > Cc: crash-catcher(a)lists.fedorahosted.org
> > Subject: Re: [Crash-catcher] bugzilla report always crashed
> >
> > Dne 15.2.2010 19:12, Zhu, Peter J napsal(a):
> >      
> >> Hi,
> >>
> >>        
> >>> Hello,
> >>>
> >>> could you send me backtrace and rpm -q abrt? Try to update to the newest
> >>>          
> > abrt-1.0.7
> >      
> >>>          
> >> Please see http://pastebin.com/md85ca75 for backtrace, it crashed as it
> >>        
> > tried to remove reference to result.
> >      
> >> Where can I download 1.0.7?
> >>
> >> Thanks,
> >> Peter
> >>
> >>
> >>        
> > yum --enablerepo=updates-testing update abrt
> >
> >      
>  Are you sure it works? I double checked and there is no abrt in updates-testing repo.
>
>  Peter
>      
Or you can manually download it from fedora updates.
Link: 
https://admin.fedoraproject.org/updates/abrt-1.0.7-1.fc12?_csrf_token=9f1...

Bad news is that bug is still present in a new version and what is worst 
I can't reproduce it. My opinion is that it is caused by 
xmlrpc_DECREF(NULL). It should be fixed in my local git repository and 
it will be in a new version(1.0.8). If you want to I will send you a patch.

-- 
Nikola

[Zhu, Peter J]

Hi

>  Or you can manually download it from fedora updates.
>  Link:
>  https://admin.fedoraproject.org/updates/abrt-1.0.7-1.fc12?_csrf_token=9f14c
>  32e003641037ce6dd0b4a73b59526f451b8
>  
>  Bad news is that bug is still present in a new version and what is worst
>  I can't reproduce it. My opinion is that it is caused by
>  xmlrpc_DECREF(NULL). It should be fixed in my local git repository and
>  it will be in a new version(1.0.8). If you want to I will send you a patch.
>   
Thanks for your info. I'm now using 1.0.7. The crash won't happen if I check if
result is NULL. But I run into a new problem with add_attachment(). Abrtd reports
following:
    abrtd: Update(':1.285'): Reporting via 'Bugzilla' was not successful:
XML-RPC Fault: Unable to make sense of XML-RPC response from server.  Invalid struct for
<fault> value.  Invalid value for 'faultCode' member.  Value of type STRING
supplied where type INT was expected..  Use XMLRPC_TRACE_XML to see for yourself(-503)

By setting env, I got below response with Bugzilla.addAttachment call. 
    <?xml version="1.0"
encoding="UTF-8"?><methodResponse><fault><value><struct><member><name>faultString</name><value><string>Can't
call method "login_exempt" on an undefined value at Bugzilla/WebService.pm line
51.\n
   
</string></value></member><member><name>faultCode</name><value><string>Client</string></value></member></struct></value></fault></methodResponse>

I never called login_exempt(). Any idea? 

BTW, from the link, 1.0.7 can work behind firewall. Where do I set proxy so that abrt can
work behind a firewall?

Peters

[Denys Vlasenko]

On Tue, 2010-02-16 at 12:01 +0100, Nikola Pajkovsky wrote:
>  My opinion is that it is caused by 
>  xmlrpc_DECREF(NULL). It should be fixed in my local git repository and 
>  it will be in a new version(1.0.8). If you want to I will send you a patch. 

It's quite shocking that xmlrpc-c indeed does not follow the
"free(NULL) is safe" tradition. Their source code is:


xmlrpc_DECREF (xmlrpc_value * const valueP) {

    XMLRPC_ASSERT_VALUE_OK(valueP);
    XMLRPC_ASSERT(valueP->_refcount > 0);
    XMLRPC_ASSERT(valueP->_type != XMLRPC_TYPE_DEAD);

    valueP->_refcount--;

    /* If we have no more refs, we need to deallocate this value. */
    if (valueP->_refcount == 0)
        destroyValue(valueP);
}

NULL valueP is not safe. 8(

--
vda