10:18 a.m.
- closes rhbz#917684
Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
---
src/workflows/anaconda_event.conf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/workflows/anaconda_event.conf b/src/workflows/anaconda_event.conf
index fda7239..f71aebd 100644
--- a/src/workflows/anaconda_event.conf
+++ b/src/workflows/anaconda_event.conf
@@ -1,2 +1,2 @@
-EVENT=workflow_AnacondaBugzilla type=anaconda
-EVENT=workflow_AnacondaUpload type=anaconda
\ No newline at end of file
+EVENT=workflow_AnacondaFedora type=anaconda
+EVENT=workflow_AnacondaUpload type=anaconda
--
1.8.1.4
10:18 a.m.
New subject: [LIBREPORT PATCH 2/3] workflows: a less confusing event name for reporting to Fedora infrastructure
- related to rhbz#917694
Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
---
src/workflows/workflow_AnacondaFedora.xml.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/workflows/workflow_AnacondaFedora.xml.in
b/src/workflows/workflow_AnacondaFedora.xml.in
index 5efc9d0..1920ff0 100644
--- a/src/workflows/workflow_AnacondaFedora.xml.in
+++ b/src/workflows/workflow_AnacondaFedora.xml.in
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" ?>
<workflow>
- <_name>Report to Fedora</_name>
+ <_name>Send a report to Fedora</_name>
<_description>Process the report using the Fedora
infrastructure</_description>
<events>
--
1.8.1.4
3:26 a.m.
New subject: [LIBREPORT PATCH 2/3] workflows: a less confusing event name for reporting to Fedora infrastructure
On Mon, 2013-03-04 at 17:18 +0100, Jakub Filak wrote:
- related to rhbz#917694
Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
---
src/workflows/workflow_AnacondaFedora.xml.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/workflows/workflow_AnacondaFedora.xml.in
b/src/workflows/workflow_AnacondaFedora.xml.in
index 5efc9d0..1920ff0 100644
--- a/src/workflows/workflow_AnacondaFedora.xml.in
+++ b/src/workflows/workflow_AnacondaFedora.xml.in
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" ?>
<workflow>
- <_name>Report to Fedora</_name>
+ <_name>Send a report to Fedora</_name>
<_description>Process the report using the Fedora
infrastructure</_description>
<events>
People are used to the word "bugzilla" and they are
searching for it.
Can we use something like "Send a report to Fedora's bugzilla"?
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
3:37 a.m.
New subject: [LIBREPORT PATCH 2/3] workflows: a less confusing event name for reporting to Fedora infrastructure
On 03/07/2013 10:26 AM, Vratislav Podzimek wrote:
On Mon, 2013-03-04 at 17:18 +0100, Jakub Filak wrote:
> - related to rhbz#917694
>
> Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
> ---
> src/workflows/workflow_AnacondaFedora.xml.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/workflows/workflow_AnacondaFedora.xml.in
b/src/workflows/workflow_AnacondaFedora.xml.in
> index 5efc9d0..1920ff0 100644
> --- a/src/workflows/workflow_AnacondaFedora.xml.in
> +++ b/src/workflows/workflow_AnacondaFedora.xml.in
> @@ -1,6 +1,6 @@
> <?xml version="1.0" encoding="UTF-8" ?>
> <workflow>
> - <_name>Report to Fedora</_name>
> + <_name>Send a report to Fedora</_name>
> <_description>Process the report using the Fedora
infrastructure</_description>
>
> <events>
People are used to the word "bugzilla" and they are searching for it.
Can we use something like "Send a report to Fedora's bugzilla"?
- I'm for "Report a bug to Fedora maintainers"
--Jirka
3:42 a.m.
New subject: [LIBREPORT PATCH v2 1/3] workflows: correct an event name for reporting to Fedora in anaconda config
- closes rhbz#917684
Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
---
src/workflows/anaconda_event.conf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/workflows/anaconda_event.conf b/src/workflows/anaconda_event.conf
index fda7239..f71aebd 100644
--- a/src/workflows/anaconda_event.conf
+++ b/src/workflows/anaconda_event.conf
@@ -1,2 +1,2 @@
-EVENT=workflow_AnacondaBugzilla type=anaconda
-EVENT=workflow_AnacondaUpload type=anaconda
\ No newline at end of file
+EVENT=workflow_AnacondaFedora type=anaconda
+EVENT=workflow_AnacondaUpload type=anaconda
--
1.8.1.4
3:42 a.m.
New subject: [LIBREPORT PATCH v2 2/3] workflows: a less confusing event name for reporting to Fedora infrastructure
- related to rhbz#917694
----
v2: s/Send a report to Fedora/Report a bug to Fedora maintainers/
Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
---
src/workflows/workflow_AnacondaFedora.xml.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/workflows/workflow_AnacondaFedora.xml.in
b/src/workflows/workflow_AnacondaFedora.xml.in
index 5efc9d0..5c8c2a7 100644
--- a/src/workflows/workflow_AnacondaFedora.xml.in
+++ b/src/workflows/workflow_AnacondaFedora.xml.in
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" ?>
<workflow>
- <_name>Report to Fedora</_name>
+ <_name>Report a bug to Fedora maintainers</_name>
<_description>Process the report using the Fedora
infrastructure</_description>
<events>
--
1.8.1.4
5:54 a.m.
New subject: [LIBREPORT PATCH v2 2/3] workflows: a less confusing event name for reporting to Fedora infrastructure
On Thu, 2013-03-07 at 10:42 +0100, Jakub Filak wrote:
- related to rhbz#917694
----
v2: s/Send a report to Fedora/Report a bug to Fedora maintainers/
Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
---
src/workflows/workflow_AnacondaFedora.xml.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/workflows/workflow_AnacondaFedora.xml.in
b/src/workflows/workflow_AnacondaFedora.xml.in
index 5efc9d0..5c8c2a7 100644
--- a/src/workflows/workflow_AnacondaFedora.xml.in
+++ b/src/workflows/workflow_AnacondaFedora.xml.in
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" ?>
<workflow>
- <_name>Report to Fedora</_name>
+ <_name>Report a bug to Fedora maintainers</_name>
<_description>Process the report using the Fedora
infrastructure</_description>
<events>
Looks good to me.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
3:42 a.m.
New subject: [LIBREPORT PATCH v2 3/3] report-gtk: prettify the workflow buttons
- closes rhbz#917694
Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
---
src/gui-wizard-gtk/wizard.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
index 7e8f419..d6035c4 100644
--- a/src/gui-wizard-gtk/wizard.c
+++ b/src/gui-wizard-gtk/wizard.c
@@ -2513,6 +2513,10 @@ static void add_workflow_buttons(GtkBox *box, GHashTable
*workflows, GCallback f
GList *children = gtk_container_get_children(GTK_CONTAINER(button));
GtkWidget *label = (GtkWidget *)children->data;
gtk_label_set_use_markup(GTK_LABEL(label), true);
+ gtk_widget_set_halign(label, GTK_ALIGN_START);
+ gtk_widget_set_margin_top(label, 10);
+ gtk_widget_set_margin_left(label, 40);
+ gtk_widget_set_margin_bottom(label, 10);
free(btn_label);
g_signal_connect(button, "clicked", func, w);
gtk_box_pack_start(box, button, true, false, 2);
--
1.8.1.4
10:18 a.m.
New subject: [LIBREPORT PATCH 3/3] report-gtk: prettify the workflow buttons
- closes rhbz#917694
Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
---
src/gui-wizard-gtk/wizard.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
index 7e8f419..d6035c4 100644
--- a/src/gui-wizard-gtk/wizard.c
+++ b/src/gui-wizard-gtk/wizard.c
@@ -2513,6 +2513,10 @@ static void add_workflow_buttons(GtkBox *box, GHashTable
*workflows, GCallback f
GList *children = gtk_container_get_children(GTK_CONTAINER(button));
GtkWidget *label = (GtkWidget *)children->data;
gtk_label_set_use_markup(GTK_LABEL(label), true);
+ gtk_widget_set_halign(label, GTK_ALIGN_START);
+ gtk_widget_set_margin_top(label, 10);
+ gtk_widget_set_margin_left(label, 40);
+ gtk_widget_set_margin_bottom(label, 10);
free(btn_label);
g_signal_connect(button, "clicked", func, w);
gtk_box_pack_start(box, button, true, false, 2);
--
1.8.1.4
3:27 a.m.
On Mon, 2013-03-04 at 17:18 +0100, Jakub Filak wrote:
- closes rhbz#917684
Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
---
src/workflows/anaconda_event.conf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/workflows/anaconda_event.conf b/src/workflows/anaconda_event.conf
index fda7239..f71aebd 100644
--- a/src/workflows/anaconda_event.conf
+++ b/src/workflows/anaconda_event.conf
@@ -1,2 +1,2 @@
-EVENT=workflow_AnacondaBugzilla type=anaconda
-EVENT=workflow_AnacondaUpload type=anaconda
\ No newline at end of file
+EVENT=workflow_AnacondaFedora type=anaconda
+EVENT=workflow_AnacondaUpload type=anaconda
Apart from the comment on button label
these three look good to me.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
4106
days inactive
4109
days old
crash-catcher@lists.fedorahosted.org
9 comments
3 participants
participants (3)
-
Jakub Filak -
Jiri Moskovcak -
Vratislav Podzimek