[PATCH] trac#522 : abrt vmcore plugin verbosity correction

[Jakub Filak]

---
 src/plugins/abrt-action-analyze-vmcore.in    |    7 +++++--
 src/plugins/abrt-action-install-debuginfo.in |    2 ++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/plugins/abrt-action-analyze-vmcore.in
b/src/plugins/abrt-action-analyze-vmcore.in
index af606c4..c3f2e2e 100644
--- a/src/plugins/abrt-action-analyze-vmcore.in
+++ b/src/plugins/abrt-action-analyze-vmcore.in
@@ -25,7 +25,7 @@ if __name__ == "__main__":
     vmlinux_di_path = ""
     tmpdir = ""
     vmcore = ""
-    global verbose
+
     help_text = _("Usage: {0} [-v[v]] [--core=VMCORE] [--tmpdir=TMPDIR]
[--cache=CACHEDIR]").format(PROGNAME)
     try:
         opts, args = getopt.getopt(sys.argv[1:], "hvd", ["help",
"tmpdir=", "cache=", "core="])
@@ -114,7 +114,10 @@ if __name__ == "__main__":
                 error_msg_and_die(_("Can't download required debuginfo"))
             vmlinux_di_path =
"{0}/usr/lib/debug/lib/modules/{1}/vmlinux".format(vmlinux_di_cachedir, ver)
         else: # we need to use the suid wrapper, if we use the default cache
-            downloader =
Popen(["/usr/libexec/abrt-action-install-debuginfo-to-abrt-cache",
"--size_mb=4096", "--exact={0}".format(vmlinux_di_path)], bufsize =
-1)
+            downloader_args =
["/usr/libexec/abrt-action-install-debuginfo-to-abrt-cache",
"--size_mb=4096", "--exact={0}".format(vmlinux_di_path)]
+            if verbose > 0:
+                downloader_args.append("-{0}".format("v"*verbose))
+            downloader = Popen(downloader_args, bufsize = -1)
             res = downloader.wait()
             if res != 0:
                 error_msg_and_die(_("Can't download required debuginfo"))
diff --git a/src/plugins/abrt-action-install-debuginfo.in
b/src/plugins/abrt-action-install-debuginfo.in
index a6c39f3..a061fa6 100644
--- a/src/plugins/abrt-action-install-debuginfo.in
+++ b/src/plugins/abrt-action-install-debuginfo.in
@@ -134,6 +134,8 @@ if __name__ == "__main__":
             missing=arg.split(':')
             exact_fls = True
 
+    set_verbosity(verbose)
+
     if not cachedirs:
         try:
             fp = open("@sysconfdir@/@PACKAGE_NAME(a)/plugins/CCpp.conf",
"r")
-- 
1.7.7.6

[Jiri Moskovcak]

- Ack

On 04/10/2012 01:33 PM, Jakub Filak wrote:
>  ---
>    src/plugins/abrt-action-analyze-vmcore.in    |    7 +++++--
>    src/plugins/abrt-action-install-debuginfo.in |    2 ++
>    2 files changed, 7 insertions(+), 2 deletions(-)
>
>  diff --git a/src/plugins/abrt-action-analyze-vmcore.in
> b/src/plugins/abrt-action-analyze-vmcore.in
>  index af606c4..c3f2e2e 100644
>  --- a/src/plugins/abrt-action-analyze-vmcore.in
>  +++ b/src/plugins/abrt-action-analyze-vmcore.in
>  @@ -25,7 +25,7 @@ if __name__ == "__main__":
>        vmlinux_di_path = ""
>        tmpdir = ""
>        vmcore = ""
>  -    global verbose
>  +
>        help_text = _("Usage: {0} [-v[v]] [--core=VMCORE] [--tmpdir=TMPDIR]
> [--cache=CACHEDIR]").format(PROGNAME)
>        try:
>            opts, args = getopt.getopt(sys.argv[1:], "hvd", ["help",
> "tmpdir=", "cache=", "core="])
>  @@ -114,7 +114,10 @@ if __name__ == "__main__":
>                    error_msg_and_die(_("Can't download required
> debuginfo"))
>                vmlinux_di_path =
> "{0}/usr/lib/debug/lib/modules/{1}/vmlinux".format(vmlinux_di_cachedir, ver)
>            else: # we need to use the suid wrapper, if we use the default cache
>  -            downloader =
> Popen(["/usr/libexec/abrt-action-install-debuginfo-to-abrt-cache",
> "--size_mb=4096", "--exact={0}".format(vmlinux_di_path)], bufsize =
> -1)
>  +            downloader_args =
> ["/usr/libexec/abrt-action-install-debuginfo-to-abrt-cache",
> "--size_mb=4096", "--exact={0}".format(vmlinux_di_path)]
>  +            if verbose>  0:
>  +                downloader_args.append("-{0}".format("v"*verbose))
>  +            downloader = Popen(downloader_args, bufsize = -1)
>                res = downloader.wait()
>                if res != 0:
>                    error_msg_and_die(_("Can't download required
> debuginfo"))
>  diff --git a/src/plugins/abrt-action-install-debuginfo.in
> b/src/plugins/abrt-action-install-debuginfo.in
>  index a6c39f3..a061fa6 100644
>  --- a/src/plugins/abrt-action-install-debuginfo.in
>  +++ b/src/plugins/abrt-action-install-debuginfo.in
>  @@ -134,6 +134,8 @@ if __name__ == "__main__":
>                missing=arg.split(':')
>                exact_fls = True
>
>  +    set_verbosity(verbose)
>  +
>        if not cachedirs:
>            try:
>                fp = open("@sysconfdir@/@PACKAGE_NAME(a)/plugins/CCpp.conf",
> "r")