[GNOME-ABRT PATCH] Display 'component' name instead of 'executable' if desktop file is missing

[Jakub Filak]

Closes #20

Signed-off-by: Jakub Filak <jfilak(a)redhat.com&gt;
---
 src/gnome_abrt/application.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/gnome_abrt/application.py b/src/gnome_abrt/application.py
index ae32113..fd1cdd2 100644
--- a/src/gnome_abrt/application.py
+++ b/src/gnome_abrt/application.py
@@ -31,12 +31,14 @@ from gi.repository import GdkPixbuf
 class Application(object):
 
     def __init__(self, executable, name=None, icon=None):
-        self.executable = executable
+        self.executable = executable or "??"
 
         if name:
             self.name = name
-        else:
+        elif executable:
             self.name = os.path.basename(executable)
+        else:
+            self.name = "??"
 
         self.icon = icon
 
@@ -137,4 +139,4 @@ def find_application(component, executable, cmdline):
                                                         icon=icon)
                 return __globa_app_cache__[pred[0]]
 
-    return Application(executable if executable else "??")
+    return Application(executable, name=component)
-- 
1.8.1.4

[Richard Marko]

Pushed, thanks for flying abrt.

On 04/12/2013 10:45 AM, Jakub Filak wrote:
>  Closes #20
>
>  Signed-off-by: Jakub Filak <jfilak(a)redhat.com&gt;
>  ---
>   src/gnome_abrt/application.py | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
>  diff --git a/src/gnome_abrt/application.py b/src/gnome_abrt/application.py
>  index ae32113..fd1cdd2 100644
>  --- a/src/gnome_abrt/application.py
>  +++ b/src/gnome_abrt/application.py
>  @@ -31,12 +31,14 @@ from gi.repository import GdkPixbuf
>   class Application(object):
>   
>       def __init__(self, executable, name=None, icon=None):
>  -        self.executable = executable
>  +        self.executable = executable or "??"
>   
>           if name:
>               self.name = name
>  -        else:
>  +        elif executable:
>               self.name = os.path.basename(executable)
>  +        else:
>  +            self.name = "??"
>   
>           self.icon = icon
>   
>  @@ -137,4 +139,4 @@ def find_application(component, executable, cmdline):
>                                                           icon=icon)
>                   return __globa_app_cache__[pred[0]]
>   
>  -    return Application(executable if executable else "??")
>  +    return Application(executable, name=component) 


-- 
Richard Marko