deltacloud-devel March 2010

deltacloud-devel@lists.fedorahosted.org

15 participants
103 discussions

[PATCH portal 1/2] allow optional permission obj param to the has_foo? helper methods
by Scott Seago 30 Mar '10

30 Mar '10

So to check 'provider_view' privilege for the "current object" then call as before: has_provider_view? To check against a specific object then pass it in as a parameter: has_quota_modify?(pool) has_pool_view?(BasePortalObject.general_permission_scope Signed-off-by: Scott Seago <sseago(a)redhat.com> --- src/app/controllers/application_controller.rb | 4 ++-- src/app/services/application_service.rb | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/app/controllers/application_controller.rb b/src/app/controllers/application_controller.rb index 214eb2b..d7b135b 100644 --- a/src/app/controllers/application_controller.rb +++ b/src/app/controllers/application_controller.rb @@ -56,8 +56,8 @@ class ApplicationController < ActionController::Base perm_helper_string = "" Privilege::FULL_PRIVILEGE_LIST.each do |privilege| - perm_helper_string += "def has_#{privilege}?; " + - "check_privilege(\"#{privilege}\") end; " + perm_helper_string += "def has_#{privilege}?(obj=@perm_obj); " + + "check_privilege(\"#{privilege}\", obj) end; " end master_helper_module.module_eval perm_helper_string diff --git a/src/app/services/application_service.rb b/src/app/services/application_service.rb index e2c45cb..f72f83d 100644 --- a/src/app/services/application_service.rb +++ b/src/app/services/application_service.rb @@ -40,14 +40,14 @@ module ApplicationService # @current_user must be defined - def check_privilege(privilege) - ((@perm_obj and @perm_obj.has_privilege(@current_user, privilege)) or + def check_privilege(privilege, perm_obj) + ((perm_obj and perm_obj.has_privilege(@current_user, privilege)) or BasePortalObject.general_permission_scope.has_privilege(@current_user, privilege)) end def authorized?(privilege, perm_obj=nil) @perm_obj = perm_obj - check_privilege(privilege) + check_privilege(privilege,@perm_obj) end def require_privilege(privilege, perm_obj=nil) unless authorized?(privilege, perm_obj) -- 1.6.2.5

2 2

[PATCH docs 3/3] Add steps to setup an admin into the README.
by Tomas Sedovic 30 Mar '10

30 Mar '10

From: Tomas Sedovic <tsedovic(a)redhat.com> --- README.txt | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/README.txt b/README.txt index c126498..75d7243 100644 --- a/README.txt +++ b/README.txt @@ -164,3 +164,12 @@ Checking out the UI ------------------- Now that you have all of the components running, you should be able to point your web browser at <http://localhost:3000> and see the Aggregator page. + +To be able to use it properly, you will need to create a user. You can do it on +the Aggregator website. Users created this way have limited privileges, however. +We recommend setting up one user as an administrator of the site. + +This is how you turn an existing user into an admin: + + $ cd path/to/deltacloud/portal/src + $ rake dc:site_admin[aggregator_username] -- 1.6.6.1

2 1

[PATCH] Changes allowing a privileged user creates a user account for somebody else
by Mo Morsi 30 Mar '10

30 Mar '10

--- src/app/controllers/users_controller.rb | 10 +++++++--- src/spec/controllers/users_controller_spec.rb | 25 ++++++++++++++++++++++++- 2 files changed, 31 insertions(+), 4 deletions(-) diff --git a/src/app/controllers/users_controller.rb b/src/app/controllers/users_controller.rb index 6c6c021..3536c0e 100644 --- a/src/app/controllers/users_controller.rb +++ b/src/app/controllers/users_controller.rb @@ -20,7 +20,6 @@ # Likewise, all the methods added will be available for all controllers. class UsersController < ApplicationController - before_filter :require_no_user, :only => [:new, :create] before_filter :require_user, :only => [:show, :edit, :update] def new @@ -28,18 +27,23 @@ class UsersController < ApplicationController end def create + require_privilege(Privilege::USER_MODIFY) unless current_user.nil? @user = User.new(params[:user]) @registration = RegistrationService.new(@user) if @registration.save flash[:notice] = "User registered!" - redirect_back_or_default account_url + redirect_back_or_default url_for(:action => :show, :id => @user.id) else render :action => :new end end def show - @user = @current_user + if params.has_key?(:id) && params[:id] != "show" + @user = User.find(params[:id]) + else + @user = current_user + end end def edit diff --git a/src/spec/controllers/users_controller_spec.rb b/src/spec/controllers/users_controller_spec.rb index 5f010cc..1c3a8fd 100644 --- a/src/spec/controllers/users_controller_spec.rb +++ b/src/spec/controllers/users_controller_spec.rb @@ -4,6 +4,8 @@ describe UsersController do fixtures :all before(:each) do @tuser = Factory :tuser + @admin_permission = Factory :admin_permission + @admin = @admin_permission.user activate_authlogic end @@ -35,7 +37,8 @@ describe UsersController do p.permissions.any? { |perm| perm.role.name.eql?('Self-service Pool User') }.should be_true - response.should redirect_to(account_path) + id = User.find(:first, :conditions => ['login = ?', "tuser2"]).id + response.should redirect_to("http://test.host/users/show/#{id}") end it "fails to create pool" do @@ -59,6 +62,26 @@ describe UsersController do end end + it "should allow an admin to create user" do + UserSession.create(@admin) + lambda { + post :create, :user => { :login => "tuser3", :email => "tuser3(a)example.com", + :password => "testpass", + :password_confirmation => "testpass" } + }.should change{ User.count } + id = User.find(:first, :conditions => ['login = ?', "tuser3"]).id + response.should redirect_to("http://test.host/users/show/#{id}") + end + + it "should not allow a regular user to create user" do + UserSession.create(@tuser) + lambda { + post :create, :user => { :login => "tuser4", :email => "tuser4(a)example.com", + :password => "testpass", + :password_confirmation => "testpass" } + }.should_not change{ User.count } + end + it "should show user" do UserSession.create(@tuser) get :show -- 1.6.2.5

3 5

Getting Started guide reorg & update
by Tomas Sedovic 30 Mar '10

30 Mar '10

This replaces the previous patches about the Getting Started guide and Contribute page. With regards to Jason's comments, I've renamed getting_started.txt to README.txt, moved its first part to the website only and fixed some typos and out-of-date stuff.

2 4

[ANNOUNCE] RHEV-M web service API project
by Mark McLoughlin 30 Mar '10

30 Mar '10

Hi, We are starting a new open project to define an official web service API for RHEV-M. One of our first goals is to get the get the API up to a sufficient standard so that we can re-write the current deltacloud driver to use the new API. See these notes on those requirements: https://fedorahosted.org/rhevm-api/wiki/Deltacloud Please see the wiki here: https://fedorahosted.org/rhevm-api and join the mailing list here: https://fedorahosted.org/mailman/listinfo/rhevm-api Thanks! Mark.

1 0

[PATCH docs 1/2] Add a "how to build the website" document.
by Tomas Sedovic 29 Mar '10

29 Mar '10

From: Tomas Sedovic <tsedovic(a)redhat.com> --- building_website.txt | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 57 insertions(+), 0 deletions(-) create mode 100644 building_website.txt diff --git a/building_website.txt b/building_website.txt new file mode 100644 index 0000000..1f3a7f8 --- /dev/null +++ b/building_website.txt @@ -0,0 +1,57 @@ +How to Build the Deltacloud Website +=================================== + + +Requirements +------------ + +You need to have Ruby version 1.8 installed, along with the following gems: + +* webby +* haml +* rdiscount + +Depending on your distribution, you may need to add the directory with `webby` +executable to your $PATH. + + +Building the Website +-------------------- + +Deltacloud website is created using [Webby][1]. It takes a website defined by a +set of layouts, templates and content files, runs a count of filters on them +end produces a static web structure that can be directly posted to a webserver +or displayed in a browser. + +[1]: http://webby.rubyforge.org/ + +To do this, go to the `deltacloud.org` directory and run `webby`: + + $ cd path/to/docs/deltacloud.org + $ webby + +The website will be generated in the `deltacloud.org/output/` directory. To +view it, you can point your browser to that directory. + + file:///home/username/path/to/docs/deltacloud.org/output/ + + +File Structure +-------------- + +docs/ + - documentation for Deltacloud + +deltacloud.org/ + - the Deltacloud website + +deltacloud.org/content/ + - the pages that are displayed on the website + +deltacloud.org/layouts/ + - the structure of the website -- including logo, navigation, + footers, etc. + +deltacloud.org/output/ + - the final version of the site -- this is what you want to view in a + web browser -- 1.6.6.1

2 3

Dependency update in getting_started.txt
by Tomas Sedovic 29 Mar '10

29 Mar '10

Martin Taylor pointed out on two gems that were not listed in the Getting Started guide. Apply this patch on top of the previous docs patch -- commit 6036ee3511fa764223cb588ab99a31f8a98d1447 (the one that merges getting_started.txt with the Contribute page).

1 1

Fedora init script and configuration
by Michal Fojtik 26 Mar '10

26 Mar '10

Hi, I created a simple init script for Fedora with sysconfig configuration for API. Both of these are placed in 'support/fedora' directory and it will be part of Fedora RPM. Second patch allowing Thin to be run on background (this mode is used for initscript). Howto test: 0. be sure, you have all necessary gems installed to run API 1. rake install[/usr/share/deltacloud-core, /usr/bin] 2. cp support/fedora/deltacloudd /etc/init.d 3. cp support/fedora/sysconfig_deltacloudd /etc/sysconfig/deltacloudd 4. /etc/init.d/deltacloudd start 5. navigate to http://localhost:3001 6. /etc/init.d/deltacloudd restart 7. /etc/init.d/deltacloudd stop - Michal

2 6

Fixed Mock driver for Cucumber
by Michal Fojtik 26 Mar '10

26 Mar '10

Hi, Only few small fixed in order to get green color for all Cucumber scenarios in API. After applying this patch you will luckily get: http://mifo.sk/cucumber_mock.html - Michal

2 3

Table for supported providers & features
by Tomas Sedovic 25 Mar '10

25 Mar '10

This patch adds the table of popular providers and lists which features do we support. Included is some temporary styling, but it's no substitution for a real design. The table can be found in Documentation -> Drivers on the website.

2 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

deltacloud-devel March 2010