Re: [deltacloud-devel] [PATCH aggregator] BZ #643121: small tweak to edit user form style

[Jakub Steiner]

I don't like this. The change has broken the login dialog (fields way too narrow - 10em as opposed to 20em). The issue here is that .modalbox wrapper should not be used for the edit page. It's only used for login and for self service creating a new account by the user. Once logged in, the form should not be wrapped in .modalbox

cheers

[PATCH aggregator] BZ #643121: small tweak to edit user form style

[Mo Morsi]

On 10/21/2010 06:48 AM, Jakub Steiner wrote:
> I don't like this. The change has broken the login dialog (fields way too narrow - 10em as opposed to 20em). The issue here is that .modalbox wrapper should not be used for the edit page. It's only used for login and for self service creating a new account by the user. Once logged in, the form should not be wrapped in .modalbox
>
> cheers

This is not true. The 'new user' form is always wrapped in the modal box 
regardless of whether or not it is the self-service case. eg even if an 
admin is logged in creating a new user for someone else, the form is 
currently wrapped in the modalbox. I don't see what the objection to 
using the modalbox on the edit user form is, everything falls into place 
after that, errors are not being displayed otherwise.

The real problem isn't that the form is in a modal box, its that the 
input field size was set too small. Granted I'll admit I should've 
considered other elements on the site affected by this change and simply 
added a new style rule which just applies to the large buttons on the 
edit user form (without the style change they are broken up into 
multiple lines). But I do object to reverting my whole patch, especially 
when I wasn't around to discuss this. Your new patch doesn't work in 
solving the original problem, errors on the edit user form are now not 
being displayed again.

https://bugzilla.redhat.com/show_bug.cgi?id=643121

Lets try to work together to come up with a solution that works for 
everyone, perhaps through the combination of both our patches.

-Mo