Re: [deltacloud-devel] [PATCH core 2/3] Added fetch_documentation method

[David Lutterkort]

On Thu, 2010-02-18 at 15:57 +0100, [e-mail] wrote:
> def instances
> def instances(id=nil)
>   instances = []
>   request( entry_points[:instances] ) do |response|
>     doc = REXML::Document.new( response.body )
>
> @@ -249,7 +281,7 @@ class DeltaCloud
>      end
>    end
> def storage_volumes
> def storage_volumes(id=nil)
>   storage_volumes = []
>   request( entry_points[:storage_volumes] ) do |response|
>     doc = REXML::Document.new( response.body )
>
> @@ -278,7 +310,7 @@ class DeltaCloud
>      nil
>    end
> def storage_snapshots()
> def storage_snapshots(id=nil)
>   storage_snapshots = []
>   request( entry_points[:storage_snapshots] ) do |response|
>     doc = REXML::Document.new( response.body )

Why are you adding these id parameters ? They aren't used in the method
bodies at all.
> @@ -345,7 +377,7 @@ class DeltaCloud
>        :authorization => "Basic "+Base64.encode64("#{@name}:#{@password}"),
>        :accept => "application/xml"
>      }
> logger << "Request [#{method.to_s.upcase}] #{request_path}]\n"
> # logger << "Request [#{method.to_s.upcase}] #{request_path}]\n"
> if method.eql?(:get)
>   RestClient.send(method, request_path, headers, &block)
> else

We should find a way to conditionally log this, maybe controlled by some
env variable.

David