On 10/19/2010 10:23 PM, Mohammed Morsi wrote:
Currently when a user adds a package to a new template, a temporary template gets created for use until the form is submitted. If the user cancels the form, the template still exists when it should not. This patch simply changes the create template logic to only create the template when the form is submitted
This patch now works both when javascript is enabled and disabled.
Mostly ACK, this patch looks good and makes code cleaner. There are still some bugs in this code: - template id in controller actions is not checked properly and w/o JS throws exceptions on some places (see attachment) - group selection doesn't work - "show all" link doesn't work - this patch expects that all selected packages are submited for each "add select" action (user can't add packages incrementally), it's not problem now, but will be problem with new selection model.
All bugs (except ids) are related to current selection model which we are now reworking, so there is no reason for spending time by fixing them.
So ACK with ids fix. Rest of above problems will be solved with new selection model, but this patch should be pushed into beta only with new selection model.
Jan