On Fri, 2010-07-23 at 13:18 -0400, Jason Guiditta wrote:
On Tue, 2010-07-20 at 17:27 +0200, tsedovic@redhat.com wrote:
ACK, this look fine, and is a good first step toward completely removing that sidebar. Other remaining bits I see from this that need doing are:
- Remove sidebar from instances page. If you have more than one pool,
you should go to a grid view entry page - I can dig up jeremy's mockup for this if it is not readily available.
- Bunch of references (and one sass file) with name dcloud. This is an
old reference that should go away.
- Start making more use of sass' mixin modules and blueprint.css,
otherwise we aren't getting the real benefit of using compass here.
Shame of me for forget to running 'rake cucumber' before ACKing this. Said command produces the following errors as a result of these UI changes:
......F--------.....F---.....F----.....F---...................................
(::) failed steps (::)
Could not find link with text or title or id "Add a pool" (Webrat::NotFoundError) ./features/step_definitions/web_steps.rb:28:in `/^(?:|I )follow "([^"]*)"$/' features/pool.feature:13:in `When I follow "Add a pool"'
Could not find link with text or title or id "mockpool" (Webrat::NotFoundError) ./features/step_definitions/web_steps.rb:28:in `/^(?:|I )follow "([^"]*)"$/' features/pool.feature:31:in `When I follow "mockpool"'
Could not find link with text or title or id "mockpool" (Webrat::NotFoundError) ./features/step_definitions/web_steps.rb:28:in `/^(?:|I )follow "([^"]*)"$/' features/pool.feature:43:in `When I follow "mockpool"'
Could not find link with text or title or id "mockpool" (Webrat::NotFoundError) ./features/step_definitions/web_steps.rb:28:in `/^(?:|I )follow "([^"]*)"$/' features/pool.feature:65:in `When I follow "mockpool"'
Failing Scenarios: cucumber features/pool.feature:10 # Scenario: Create a new Pool cucumber features/pool.feature:23 # Scenario: View Pool's Hardware Profiles cucumber features/pool.feature:39 # Scenario: View Pool's Realms cucumber features/pool.feature:50 # Scenario: View Pool's Quota Usage
9 scenarios (4 failed, 5 passed) 76 steps (4 failed, 18 skipped, 54 passed) 0m4.757s rake aborted!
Patch to repair this will be sent momentarily.
-j