[PATCH aggregator] Integration of rack-restful_submit

As we already started to work on our new UI with new organizations of
our controllers I thought that we could also get better when it comes to 
writing controllers RESTful way.

To fully accomplish RESTful architecture in our application where we
cannot rely on Javascript I have created project called rack-restful_submit
that actually emulates RESTful behaviour or our forms without Javascript
and with multiple submit buttons inside one form.

This patch is first integration patch of this work.
You can read more about it and look at the code here:
https://github.com/martincik/rack-restful_submit

It this email and everything else isn't enough for you to understand
let me know and I can write/explain more.

Thank you for review and happy RESTfulying. ;)

-- Ladislav

From: Ladislav Martincik <lmartinc(a)redhat.com&gt;

---
 src/app/helpers/application_helper.rb |   18 ++++++++++++++++++
 src/config/environment.rb             |    3 +++
 2 files changed, 21 insertions(+), 0 deletions(-)

diff --git a/src/app/helpers/application_helper.rb
b/src/app/helpers/application_helper.rb
index e48851c..37330cb 100644
--- a/src/app/helpers/application_helper.rb
+++ b/src/app/helpers/application_helper.rb
@@ -172,4 +172,22 @@ module ApplicationHelper
       end
     end
   end
+
+  # Integration of rack-restful_submit convention to be able to call
+  # RESTful resources defined by Rails conventions without Javascript.
+  #
+  # Method generates 3 tags:
+  # * 2 hidden field tags to define URL and METHOD to be forwared to in RESTful env.
+  # * 1 submit field to trigger the form submission defining the action
+  #
+  # Example:
+  #   <tt>restful_submit_tag('Delete', 'destroy',
instance_path(@instance), 'DELETE')</tt>
+  #
+  # Learn more: https://github.com/martincik/rack-restful_submit
+  def restful_submit_tag(value, action, url, method)
+    hidden_field_tag("__map[#{action}][url]", url) <<
+    hidden_field_tag("__map[#{action}][method]", method.upcase) <<
+    submit_tag(value, :name => "__rewrite[#{action}]")
+  end
+
 end
diff --git a/src/config/environment.rb b/src/config/environment.rb
index 7d8ba2c..07c0ea0 100644
--- a/src/config/environment.rb
+++ b/src/config/environment.rb
@@ -52,6 +52,9 @@ Rails::Initializer.run do |config|
   config.gem "simple-navigation"
   config.gem "typhoeus"
   config.gem "rb-inotify"
+  config.gem 'rack-restful_submit'
+
+  config.middleware.insert_after Rack::MethodOverride, 'Rack::RestfulSubmit'
 
   config.active_record.observers = :instance_observer, :task_observer
   # Only load the plugins named here, in the order given. By default, all plugins
-- 
1.7.3.2

[Tomas Sedovic]

ACK

This (plus the gem) is wonderful. Thanks!

Thomas

On 12/10/2010 03:11 PM, lmartinc(a)redhat.com wrote:
>  From: Ladislav Martincik<lmartinc(a)redhat.com>
>
>  ---
>    src/app/helpers/application_helper.rb |   18 ++++++++++++++++++
>    src/config/environment.rb             |    3 +++
>    2 files changed, 21 insertions(+), 0 deletions(-)
>
>  diff --git a/src/app/helpers/application_helper.rb
> b/src/app/helpers/application_helper.rb
>  index e48851c..37330cb 100644
>  --- a/src/app/helpers/application_helper.rb
>  +++ b/src/app/helpers/application_helper.rb
>  @@ -172,4 +172,22 @@ module ApplicationHelper
>          end
>        end
>      end
>  +
>  +  # Integration of rack-restful_submit convention to be able to call
>  +  # RESTful resources defined by Rails conventions without Javascript.
>  +  #
>  +  # Method generates 3 tags:
>  +  # * 2 hidden field tags to define URL and METHOD to be forwared to in RESTful env.
>  +  # * 1 submit field to trigger the form submission defining the action
>  +  #
>  +  # Example:
>  +  #<tt>restful_submit_tag('Delete', 'destroy',
> instance_path(@instance), 'DELETE')</tt>
>  +  #
>  +  # Learn more: https://github.com/martincik/rack-restful_submit
>  +  def restful_submit_tag(value, action, url, method)
>  +    hidden_field_tag("__map[#{action}][url]", url)<<
>  +    hidden_field_tag("__map[#{action}][method]", method.upcase)<<
>  +    submit_tag(value, :name =>  "__rewrite[#{action}]")
>  +  end
>  +
>    end
>  diff --git a/src/config/environment.rb b/src/config/environment.rb
>  index 7d8ba2c..07c0ea0 100644
>  --- a/src/config/environment.rb
>  +++ b/src/config/environment.rb
>  @@ -52,6 +52,9 @@ Rails::Initializer.run do |config|
>      config.gem "simple-navigation"
>      config.gem "typhoeus"
>      config.gem "rb-inotify"
>  +  config.gem 'rack-restful_submit'
>  +
>  +  config.middleware.insert_after Rack::MethodOverride, 'Rack::RestfulSubmit'
>
>      config.active_record.observers = :instance_observer, :task_observer
>      # Only load the plugins named here, in the order given. By default, all plugins

[Mo Morsi]

  On 12/13/2010 04:45 AM, Tomas Sedovic wrote:
>  ACK
>
>  This (plus the gem) is wonderful. Thanks!
>
>  Thomas
>
>  On 12/10/2010 03:11 PM, lmartinc(a)redhat.com wrote:
> > From: Ladislav Martincik<lmartinc(a)redhat.com>
> >
> > ---
> >    src/app/helpers/application_helper.rb |   18 ++++++++++++++++++
> >    src/config/environment.rb             |    3 +++
> >    2 files changed, 21 insertions(+), 0 deletions(-)
> > 
Arg! We really shouldn't be adding gems to the project which aren't 
packaged into RPMs first. Also we should be careful that we don't pull 
too many external dependencies. Makes packaging deltacloud in a rpm at 
release time a hassle as there are lots of dependencies that need to be 
packaged.

At the very least could you write and test a rpm spec for your 
rack-restful_submit gem and add it to github repo. Shouldn't take too 
long to do on an individual basis. Thanks.

   -Mo

On 12/15/2010 06:10 AM, Mohammed Morsi wrote:
>     On 12/13/2010 04:45 AM, Tomas Sedovic wrote:
> > ACK
> >
> > This (plus the gem) is wonderful. Thanks!
> >
> > Thomas
> >
> > On 12/10/2010 03:11 PM, lmartinc(a)redhat.com wrote:
> >> From: Ladislav Martincik<lmartinc(a)redhat.com>
> >>
> >> ---
> >>     src/app/helpers/application_helper.rb |   18 ++++++++++++++++++
> >>     src/config/environment.rb             |    3 +++
> >>     2 files changed, 21 insertions(+), 0 deletions(-)
> >>
>  Arg! We really shouldn't be adding gems to the project which aren't
>  packaged into RPMs first. Also we should be careful that we don't pull
>  too many external dependencies. Makes packaging deltacloud in a rpm at
>  release time a hassle as there are lots of dependencies that need to be
>  packaged.
>
>  At the very least could you write and test a rpm spec for your
>  rack-restful_submit gem and add it to github repo. Shouldn't take too
>  long to do on an individual basis. Thanks.
>
>      -Mo
>  _______________________________________________
>  deltacloud-devel mailing list
>  deltacloud-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/deltacloud-devel 
Ladislav's gem is
packaged to RPM, so you can test it and help to get it 
to updates repo.

For F14: 
https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1...
For F13: 
https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1...

-- 
Jozef Zigmund

[Mo Morsi]

  On 12/15/2010 05:30 AM, Jozef Zigmund wrote:
>  On 12/15/2010 06:10 AM, Mohammed Morsi wrote:
> >
> > Arg! We really shouldn't be adding gems to the project which aren't
> > packaged into RPMs first. Also we should be careful that we don't pull
> > too many external dependencies. Makes packaging deltacloud in a rpm at
> > release time a hassle as there are lots of dependencies that need to be
> > packaged.
> >
> > At the very least could you write and test a rpm spec for your
> > rack-restful_submit gem and add it to github repo. Shouldn't take too
> > long to do on an individual basis. Thanks.
> >
> >     -Mo
> > _______________________________________________
> > deltacloud-devel mailing list
> > deltacloud-devel(a)lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/deltacloud-devel
>  Ladislav's gem is packaged to RPM, so you can test it and help to get 
>  it to updates repo.
>
>  For F14: 
>  https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1...
>  For F13: 
>  https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1...
>  
Ah cool. My bad, hadn't noticed that you submitted it to Fedora already.

   -Mo

On 12/15/2010 11:30 AM, Jozef Zigmund wrote:
>  On 12/15/2010 06:10 AM, Mohammed Morsi wrote:
> >     On 12/13/2010 04:45 AM, Tomas Sedovic wrote:
> >> ACK
> >>
> >> This (plus the gem) is wonderful. Thanks!
> >>
> >> Thomas
> >>
> >> On 12/10/2010 03:11 PM, lmartinc(a)redhat.com wrote:
> >>> From: Ladislav Martincik<lmartinc(a)redhat.com>
> >>>
> >>> ---
> >>>      src/app/helpers/application_helper.rb |   18 ++++++++++++++++++
> >>>      src/config/environment.rb             |    3 +++
> >>>      2 files changed, 21 insertions(+), 0 deletions(-)
> >>>
> > Arg! We really shouldn't be adding gems to the project which aren't
> > packaged into RPMs first. Also we should be careful that we don't pull
> > too many external dependencies. Makes packaging deltacloud in a rpm at
> > release time a hassle as there are lots of dependencies that need to be
> > packaged.
> >
> > At the very least could you write and test a rpm spec for your
> > rack-restful_submit gem and add it to github repo. Shouldn't take too
> > long to do on an individual basis. Thanks.
> >
> >      -Mo
> > _______________________________________________
> > deltacloud-devel mailing list
> > deltacloud-devel(a)lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/deltacloud-devel
>  Ladislav's gem is packaged to RPM, so you can test it and help to get it
>  to updates repo.
>
>  For F14:
>  https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1...
>  For F13:
>  https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.1...
>  
Ladislav's fixed bug in this gem, so i rebuilt this RPM package.

For F14: 
https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.2...
For F13: 
https://admin.fedoraproject.org/updates/rubygem-rack-restful_submit-1.1.2...

-- 
Jozef Zigmund