Since we don't use these now and will be switching to other charting libs (even if this just means our own fork of scruffy) when the time comes. Revised to include edits to config/environment.rb --- deltacloud-aggregator.spec.in | 3 --- src/config/environment.rb | 2 -- 2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/deltacloud-aggregator.spec.in b/deltacloud-aggregator.spec.in index f05646f..841d135 100644 --- a/deltacloud-aggregator.spec.in +++ b/deltacloud-aggregator.spec.in @@ -22,8 +22,6 @@ Requires: rubygem(will_paginate) Requires: rubygem(parseconfig) Requires: rubygem(authlogic) Requires: rubygem(deltacloud-client) >= 0.0.9.8 -Requires: rubygem(gnuplot) -Requires: rubygem(scruffy) Requires: rubygem(compass) Requires: rubygem(compass-960-plugin) Requires: rubygem(simple-navigation) @@ -36,7 +34,6 @@ Requires: rubygem(imagebuilder-console) Requires: postgresql Requires: postgresql-server Requires: ruby-postgres -Requires: gnuplot >= 4.2.6 Requires: ruby-RMagick Requires: classads >= 1.0 Requires: condor >= 7.5.4 diff --git a/src/config/environment.rb b/src/config/environment.rb index 423f224..7d8ba2c 100644 --- a/src/config/environment.rb +++ b/src/config/environment.rb @@ -47,8 +47,6 @@ Rails::Initializer.run do |config| config.gem "haml" config.gem "will_paginate" config.gem "nokogiri", :version => ">= 1.4.0" - config.gem "gnuplot" - config.gem "scruffy" config.gem "compass", :version => ">= 0.10.2" config.gem "compass-960-plugin", :lib => "ninesixty" config.gem "simple-navigation"
Hey Steve,
I think it would be a good idea to rip out any code that is dependent on these libs too, unless it's to be reused i.e. the "scruffy" code which should be able to reused with "scruffy-interactive"
If we are to reuse "scruffy" code I think we should leave in the "scruffy" lib and switch it to "scruffy-interactive" when/if the time comes. This way nothing breaks and we can wean any code off "scruffy" onto "scruffy-interactive" should there be any problems.
Cheers
Martyn
----- Original Message ----- From: "Steve Linabery" slinabery@redhat.com To: deltacloud-devel@lists.fedorahosted.org Sent: Tuesday, November 9, 2010 4:34:18 PM GMT +00:00 GMT Britain, Ireland, Portugal Subject: [deltacloud-devel] [PATCH aggregator] Remove gnuplot and scruffy deps from spec and environment.rb
Since we don't use these now and will be switching to other charting libs (even if this just means our own fork of scruffy) when the time comes. Revised to include edits to config/environment.rb --- deltacloud-aggregator.spec.in | 3 --- src/config/environment.rb | 2 -- 2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/deltacloud-aggregator.spec.in b/deltacloud-aggregator.spec.in index f05646f..841d135 100644 --- a/deltacloud-aggregator.spec.in +++ b/deltacloud-aggregator.spec.in @@ -22,8 +22,6 @@ Requires: rubygem(will_paginate) Requires: rubygem(parseconfig) Requires: rubygem(authlogic) Requires: rubygem(deltacloud-client) >= 0.0.9.8 -Requires: rubygem(gnuplot) -Requires: rubygem(scruffy) Requires: rubygem(compass) Requires: rubygem(compass-960-plugin) Requires: rubygem(simple-navigation) @@ -36,7 +34,6 @@ Requires: rubygem(imagebuilder-console) Requires: postgresql Requires: postgresql-server Requires: ruby-postgres -Requires: gnuplot >= 4.2.6 Requires: ruby-RMagick Requires: classads >= 1.0 Requires: condor >= 7.5.4 diff --git a/src/config/environment.rb b/src/config/environment.rb index 423f224..7d8ba2c 100644 --- a/src/config/environment.rb +++ b/src/config/environment.rb @@ -47,8 +47,6 @@ Rails::Initializer.run do |config| config.gem "haml" config.gem "will_paginate" config.gem "nokogiri", :version => ">= 1.4.0" - config.gem "gnuplot" - config.gem "scruffy" config.gem "compass", :version => ">= 0.10.2" config.gem "compass-960-plugin", :lib => "ninesixty" config.gem "simple-navigation"
On 11/09/10 - 12:13:05PM, Martyn Taylor wrote:
Hey Steve,
I think it would be a good idea to rip out any code that is dependent on these libs too, unless it's to be reused i.e. the "scruffy" code which should be able to reused with "scruffy-interactive"
If we are to reuse "scruffy" code I think we should leave in the "scruffy" lib and switch it to "scruffy-interactive" when/if the time comes. This way nothing breaks and we can wean any code off "scruffy" onto "scruffy-interactive" should there be any problems.
Yeah, I agree with this. If we are going to remove scruffy, let's remove it completely. If we ever need to look at the code again, it will be in git history.
On Tue, Nov 09, 2010 at 12:26:19PM -0500, Chris Lalancette wrote:
On 11/09/10 - 12:13:05PM, Martyn Taylor wrote:
Hey Steve,
I think it would be a good idea to rip out any code that is dependent on these libs too, unless it's to be reused i.e. the "scruffy" code which should be able to reused with "scruffy-interactive"
If we are to reuse "scruffy" code I think we should leave in the "scruffy" lib and switch it to "scruffy-interactive" when/if the time comes. This way nothing breaks and we can wean any code off "scruffy" onto "scruffy-interactive" should there be any problems.
Yeah, I agree with this. If we are going to remove scruffy, let's remove it completely. If we ever need to look at the code again, it will be in git history.
-- Chris Lalancette
Sounds good. I'll commence ripping.
s/e
deltacloud-devel@lists.fedorahosted.org
-
Chris Lalancette -
Martyn Taylor -
steve linabery -
Steve Linabery