NetworkManager captive portal detection by default in Workstation

[Elad Alfassa]

Hi.

I just realized we have a NetworkManager-config-connectivity-fedora
package. Installing this package will enable NetworkManager captive portal
detection by default, which allows improving user experience when
connecting to a captive portal.

We should install this by default on Workstation.

Any objections?

-- 
-Elad Alfassa.

[drago01]

On Sun, Jul 27, 2014 at 5:17 PM, Elad Alfassa <elad(a)fedoraproject.org&gt; wrote:
>  Hi.
>
>  I just realized we have a NetworkManager-config-connectivity-fedora package.
>  Installing this package will enable NetworkManager captive portal detection
>  by default, which allows improving user experience when connecting to a
>  captive portal.
>
>  We should install this by default on Workstation.
>
>  Any objections? 
Given that the captive portal stuff is all in gnome-shell instead of
installing it explicitly can't we just make gnome-shell depend on it?
Or why would one want to uninstall it?

[Elad Alfassa]

On Jul 27, 2014 5:36 PM, "drago01" <drago01(a)gmail.com&gt; wrote:
>  Given that the captive portal stuff is all in gnome-shell instead of
>  installing it explicitly can't we just make gnome-shell depend on it?
>  Or why would one want to uninstall it?
>  --
>  desktop mailing list
> desktop(a)lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/desktop 
I don't think anyone would want to remove it, making gnome-shell depend on
it is the right way to do it, we should do that.

[Elad Alfassa]

Also, to make this actually work, we need to have the patch in
https://bugzilla.redhat.com/show_bug.cgi?id=1123772 pushed to the
NetworkManager package.


-- 
-Elad Alfassa.

[Matthias Clasen]

On Sun, 2014-07-27 at 18:08 +0200, Elad Alfassa wrote:
>  
>  On Jul 27, 2014 5:36 PM, "drago01" <drago01(a)gmail.com&gt; wrote:
>  >
>  > Given that the captive portal stuff is all in gnome-shell instead of
>  > installing it explicitly can't we just make gnome-shell depend on
>  it?
>  > Or why would one want to uninstall it?
>  > --
>  > desktop mailing list
>  &gt;desktop(a)lists.fedoraproject.org
>  >https://admin.fedoraproject.org/mailman/listinfo/desktop
>  
>  I don't think anyone would want to remove it, making gnome-shell
>  depend on it is the right way to do it, we should do that. 
Sounds great to me, fwiw.

[drago01]

On Mon, Jul 28, 2014 at 2:34 PM, Matthias Clasen <mclasen(a)redhat.com&gt; wrote:
>  On Sun, 2014-07-27 at 18:08 +0200, Elad Alfassa wrote:
> >
> > On Jul 27, 2014 5:36 PM, "drago01" <drago01(a)gmail.com&gt; wrote:
> > >
> > > Given that the captive portal stuff is all in gnome-shell instead of
> > > installing it explicitly can't we just make gnome-shell depend on
> > it?
> > > Or why would one want to uninstall it?
> > > --
> > > desktop mailing list
> > &gt;desktop(a)lists.fedoraproject.org
> > >https://admin.fedoraproject.org/mailman/listinfo/desktop
> >
> > I don't think anyone would want to remove it, making gnome-shell
> > depend on it is the right way to do it, we should do that.
>
>  Sounds great to me, fwiw. 
I have added the changes but build failed due to dep issues with
pulseaudio: https://kojipkgs.fedoraproject.org//work/tasks/2780/7202780/mock_output.log

[Dan Williams]

On Mon, 2014-07-28 at 10:50 +0200, Elad Alfassa wrote:
>  Also, to make this actually work, we need to have the patch in
>  https://bugzilla.redhat.com/show_bug.cgi?id=1123772 pushed to the
>  NetworkManager package. 
Good catch, I've rebuild the F21 and rawhide packages with your patch.

Dan

[Dan Williams]

On Mon, 2014-07-28 at 14:34 +0200, Matthias Clasen wrote:
>  On Sun, 2014-07-27 at 18:08 +0200, Elad Alfassa wrote:
>  > 
>  > On Jul 27, 2014 5:36 PM, "drago01" <drago01(a)gmail.com&gt; wrote:
>  > >
>  > > Given that the captive portal stuff is all in gnome-shell instead of
>  > > installing it explicitly can't we just make gnome-shell depend on
>  > it?
>  > > Or why would one want to uninstall it?
>  > > --
>  > > desktop mailing list
>  > &gt;desktop(a)lists.fedoraproject.org
>  > >https://admin.fedoraproject.org/mailman/listinfo/desktop
>  > 
>  > I don't think anyone would want to remove it, making gnome-shell
>  > depend on it is the right way to do it, we should do that.
>  
>  Sounds great to me, fwiw. 
I see we have a dep from NM-config-connectivity-fedora back to
NetworkManager, which isn't strictly necessary since the config package
is just a config file.  GNOME Shell obviously depends on
NetworkManager-glib, but we *explicitly* made that not depend on
NetworkManager itself for the usual reasons.  Now, depending on
NM-config-connectivity-fedora would introduce a NetworkManager
dependency.  Can anyone think of a problem with that?  I'm happy to
remove the NM-ccf -> NetworkManager dep...

Dan