F32 Beta: Cursor hot point mis-positioned under Wayland

[Milan Crha]

	Hi,
I'm not sure where this should be filled, thus starting here.

I just installed Fedora-Workstation-Live-x86_64-32_Beta-1.2.iso and
booted to the Wayland session and I noticed that selecting text in the
gnome-terminal is weird. I opened the terminal and ran `ls -C1` and
tried to select some text there and it seems the cursor's hot point (or
how it is called) is the left-top corner, while the 'I' cursor uses to
have it in its center (both horizontally and vertically). It doesn't do
that under X11.

An unrelated thing, which might be probably fixed in the final release:
The first `dnf update` greeted me with this:

   Fedora 32 openh264 (From Cisco) - x86_64         86  B/s | 543  B     00:06    
   Fedora 32 openh264 (From Cisco) - x86_64        1.6 MB/s | 1.6 kB     00:00    
   Importing GPG key 0x12C944D0:
    Userid     : "Fedora (32) <fedora-32-primary(a)fedoraproject.org&gt;&quot;
    Fingerprint: 97A1 AE57 C3A2 372C CA3A 4ABA 6C13 026D 12C9 44D0
    From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-32-x86_64
   Is this ok [y/N]: 

That's something I would not expect in this stage.

	Bye,
	Milan

[Hans de Goede]

Hi,

On 3/18/20 11:01 AM, Milan Crha wrote:
>  	Hi,
>  I'm not sure where this should be filled, thus starting here.
>  
>  I just installed Fedora-Workstation-Live-x86_64-32_Beta-1.2.iso and
>  booted to the Wayland session and I noticed that selecting text in the
>  gnome-terminal is weird. I opened the terminal and ran `ls -C1` and
>  tried to select some text there and it seems the cursor's hot point (or
>  how it is called) is the left-top corner, while the 'I' cursor uses to
>  have it in its center (both horizontally and vertically). It doesn't do
>  that under X11.
>  
>  An unrelated thing, which might be probably fixed in the final release:
>  The first `dnf update` greeted me with this:
>  
>      Fedora 32 openh264 (From Cisco) - x86_64         86  B/s | 543  B     00:06
>      Fedora 32 openh264 (From Cisco) - x86_64        1.6 MB/s | 1.6 kB     00:00
>      Importing GPG key 0x12C944D0:
>       Userid     : "Fedora (32) <fedora-32-primary(a)fedoraproject.org&gt;&quot;
>       Fingerprint: 97A1 AE57 C3A2 372C CA3A 4ABA 6C13 026D 12C9 44D0
>       From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-32-x86_64
>      Is this ok [y/N]:
>  
>  That's something I would not expect in this stage. 
Hmm, I think I've seen this once too, but then I forgot about it (oops)
are you running the beta inside a virtual-machine perhaps ?

And is this a virtualbox vm by chance?

Regards,

Hans

[Milan Crha]

On Wed, 2020-03-18 at 11:26 +0100, Hans de Goede wrote:
>  are you running the beta inside a virtual-machine perhaps ?
>  
>  And is this a virtualbox vm by chance? 
	Hi,
yes, it's a virtual machine, managed by vm-manager (in says "Fedora32
on QEMU/KVM").

That might not cause any difference from the bare metal, would it? At
least with the gpg key part, which seems is the place you are replying
to.
	Bye,
	Milan

[Hans de Goede]

Hi,

On 3/18/20 11:49 AM, Milan Crha wrote:
>  On Wed, 2020-03-18 at 11:26 +0100, Hans de Goede wrote:
> > are you running the beta inside a virtual-machine perhaps ?
> >
> > And is this a virtualbox vm by chance?
>  
>  	Hi,
>  yes, it's a virtual machine, managed by vm-manager (in says "Fedora32
>  on QEMU/KVM"). 
Ok I've just tried to more exactly describe the problem as I'm
seeing it in VirtualBox here:

https://gitlab.gnome.org/GNOME/mutter/issues/1094#note_743441

Can you check if my description matches what you are seeing
in qemu/kvm ?

Regards,

Hans

[Milan Crha]

On Wed, 2020-03-18 at 12:47 +0100, Hans de Goede wrote:
>  https://gitlab.gnome.org/GNOME/mutter/issues/1094#note_743441
>  
>  Can you check if my description matches what you are seeing
>  in qemu/kvm ? 
	Hi,
yes, it does match. The part with the gnome-terminal matches exactly
what I experience.
	Thanks and bye,
	Milan

[Chris Murphy]

On Wed, Mar 18, 2020 at 4:26 AM Hans de Goede <hdegoede(a)redhat.com&gt; wrote:
>  Hi,
>
>  On 3/18/20 11:01 AM, Milan Crha wrote:
>  >       Hi,
>  > I'm not sure where this should be filled, thus starting here.
>  >
>  > I just installed Fedora-Workstation-Live-x86_64-32_Beta-1.2.iso and
>  > booted to the Wayland session and I noticed that selecting text in the
>  > gnome-terminal is weird. I opened the terminal and ran `ls -C1` and
>  > tried to select some text there and it seems the cursor's hot point (or
>  > how it is called) is the left-top corner, while the 'I' cursor uses to
>  > have it in its center (both horizontally and vertically). It doesn't do
>  > that under X11.
>  >
>  > An unrelated thing, which might be probably fixed in the final release:
>  > The first `dnf update` greeted me with this:
>  >
>  >     Fedora 32 openh264 (From Cisco) - x86_64         86  B/s | 543  B     00:06
>  >     Fedora 32 openh264 (From Cisco) - x86_64        1.6 MB/s | 1.6 kB     00:00
>  >     Importing GPG key 0x12C944D0:
>  >      Userid     : "Fedora (32)
> <fedora-32-primary(a)fedoraproject.org&gt;&quot;
>  >      Fingerprint: 97A1 AE57 C3A2 372C CA3A 4ABA 6C13 026D 12C9 44D0
>  >      From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-32-x86_64
>  >     Is this ok [y/N]:
>  >
>  > That's something I would not expect in this stage.
>
>  Hmm, I think I've seen this once too, but then I forgot about it (oops)
>  are you running the beta inside a virtual-machine perhaps ?
>
>  And is this a virtualbox vm by chance? 
I'm seeing this in virt-manager, even remotely on an f31 host so long
as the guest is f32. I'm not seeing it on a baremetal host, f31->f32
upgraded.


-- 
Chris Murphy

[Hans de Goede]

Hi,

On 3/18/20 10:48 PM, Chris Murphy wrote:
>  On Wed, Mar 18, 2020 at 4:26 AM Hans de Goede
> <hdegoede(a)redhat.com&gt; wrote:
> >
> > Hi,
> >
> > On 3/18/20 11:01 AM, Milan Crha wrote:
> >>        Hi,
> >> I'm not sure where this should be filled, thus starting here.
> >>
> >> I just installed Fedora-Workstation-Live-x86_64-32_Beta-1.2.iso and
> >> booted to the Wayland session and I noticed that selecting text in the
> >> gnome-terminal is weird. I opened the terminal and ran `ls -C1` and
> >> tried to select some text there and it seems the cursor's hot point (or
> >> how it is called) is the left-top corner, while the 'I' cursor uses to
> >> have it in its center (both horizontally and vertically). It doesn't do
> >> that under X11.
> >>
> >> An unrelated thing, which might be probably fixed in the final release:
> >> The first `dnf update` greeted me with this:
> >>
> >>      Fedora 32 openh264 (From Cisco) - x86_64         86  B/s | 543  B     00:06
> >>      Fedora 32 openh264 (From Cisco) - x86_64        1.6 MB/s | 1.6 kB     00:00
> >>      Importing GPG key 0x12C944D0:
> >>       Userid     : "Fedora (32)
> <fedora-32-primary(a)fedoraproject.org&gt;&quot;
> >>       Fingerprint: 97A1 AE57 C3A2 372C CA3A 4ABA 6C13 026D 12C9 44D0
> >>       From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-32-x86_64
> >>      Is this ok [y/N]:
> >>
> >> That's something I would not expect in this stage.
> >
> > Hmm, I think I've seen this once too, but then I forgot about it (oops)
> > are you running the beta inside a virtual-machine perhaps ?
> >
> > And is this a virtualbox vm by chance?
>  
>  I'm seeing this in virt-manager, even remotely on an f31 host so long
>  as the guest is f32. I'm not seeing it on a baremetal host, f31->f32
>  upgraded. 
Note fixing this is being worked on upstream now, there is a merge-req with
the fix for this here:

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1136

Regards,

Hans

[Olivier Fourdan]

Hi Milan

On Wed, Mar 18, 2020 at 11:04 AM Milan Crha <mcrha(a)redhat.com&gt; wrote:

>          Hi,
>  I'm not sure where this should be filled, thus starting here.
>
>  I just installed Fedora-Workstation-Live-x86_64-32_Beta-1.2.iso and
>  booted to the Wayland session and I noticed that selecting text in the
>  gnome-terminal is weird. I opened the terminal and ran `ls -C1` and
>  tried to select some text there and it seems the cursor's hot point (or
>  how it is called) is the left-top corner, while the 'I' cursor uses to
>  have it in its center (both horizontally and vertically). It doesn't do
>  that under X11.
>  [...]
>  
https://gitlab.gnome.org/GNOME/mutter/issues/1092 or
https://gitlab.gnome.org/GNOME/mutter/issues/1094 maybe?

Cheers
O.

[Milan Crha]

On Wed, 2020-03-18 at 11:44 +0100, Olivier Fourdan wrote:
>  https://gitlab.gnome.org/GNOME/mutter/issues/1092 or 
>  https://gitlab.gnome.org/GNOME/mutter/issues/1094 maybe? 
	Hi,
no HiDPI involved here, just the opposite, a virtual machine with
1024x768. I see it on both rawhide and Fedora 32. If it's not GNOME (as
one of your bug reports suggests), against what do I file it in Fedora,
please?
	Thanks and bye,
	Milan

[Olivier Fourdan]

Hi

On Wed, Mar 18, 2020 at 11:56 AM Milan Crha <mcrha(a)redhat.com&gt; wrote:

>  On Wed, 2020-03-18 at 11:44 +0100, Olivier Fourdan wrote:
>  > https://gitlab.gnome.org/GNOME/mutter/issues/1092 or
>  > https://gitlab.gnome.org/GNOME/mutter/issues/1094 maybe?
>
>  no HiDPI involved here, just the opposite, a virtual machine with
>  1024x768. I see it on both rawhide and Fedora 32. If it's not GNOME (as
>  one of your bug reports suggests), against what do I file it in Fedora,
>  please?
>  
Sorry, I did not imply that the problem was not with GNOME, I just pointed
out existing reports in mutter in case they matched your issue.

FWIW, I am running GNOME Shell on Wayland on a 1024×768 screen on bare
metal (old laptop) on F32 and I cannot reproduce that issue.

Cheers
Olivier

[Hans de Goede]

Hi,

On 3/18/20 12:11 PM, Olivier Fourdan wrote:
>  Hi
>  
>  On Wed, Mar 18, 2020 at 11:56 AM Milan Crha <mcrha(a)redhat.com
> <mailto:[e-mail]>> wrote:
>  
>      On Wed, 2020-03-18 at 11:44 +0100, Olivier Fourdan wrote:
>       > https://gitlab.gnome.org/GNOME/mutter/issues/1092 or
>       > https://gitlab.gnome.org/GNOME/mutter/issues/1094 maybe?
>  
>      no HiDPI involved here, just the opposite, a virtual machine with
>      1024x768. I see it on both rawhide and Fedora 32. If it's not GNOME (as
>      one of your bug reports suggests), against what do I file it in Fedora,
>      please?
>  
>  
>  Sorry, I did not imply that the problem was not with GNOME, I just pointed out existing
> reports in mutter in case they matched your issue.
>  
>  FWIW, I am running GNOME Shell on Wayland on a 1024×768 screen on bare metal (old laptop)
> on F32 and I cannot reproduce that issue. 
So In just checked and I can still reproduce this. I'm pretty sure this
is actually a mutter issue, this seems to be a classic cursor hotspot
issue. It seems that as soon as the hotspot is not 0x0 there are problems
when running mutter 3.36.0 as Wayland compositor in a VM.

I've added some more detailed observations to:

https://gitlab.gnome.org/GNOME/mutter/issues/1094

Which seems to be exactly this issue.

Regards,

Hans

[Hans de Goede]

Hi,

On 3/18/20 12:43 PM, Hans de Goede wrote:
>  Hi,
>  
>  On 3/18/20 12:11 PM, Olivier Fourdan wrote:
> > Hi
> >
> > On Wed, Mar 18, 2020 at 11:56 AM Milan Crha <mcrha(a)redhat.com
> <mailto:[e-mail]>> wrote:
> >
> >     On Wed, 2020-03-18 at 11:44 +0100, Olivier Fourdan wrote:
> >      > https://gitlab.gnome.org/GNOME/mutter/issues/1092 or
> >      > https://gitlab.gnome.org/GNOME/mutter/issues/1094 maybe?
> >
> >     no HiDPI involved here, just the opposite, a virtual machine with
> >     1024x768. I see it on both rawhide and Fedora 32. If it's not GNOME (as
> >     one of your bug reports suggests), against what do I file it in Fedora,
> >     please?
> >
> >
> > Sorry, I did not imply that the problem was not with GNOME, I just pointed out
> existing reports in mutter in case they matched your issue.
> >
> > FWIW, I am running GNOME Shell on Wayland on a 1024×768 screen on bare metal (old
> laptop) on F32 and I cannot reproduce that issue.
>  
>  So In just checked and I can still reproduce this. I'm pretty sure this
>  is actually a mutter issue, this seems to be a classic cursor hotspot
>  issue. It seems that as soon as the hotspot is not 0x0 there are problems
>  when running mutter 3.36.0 as Wayland compositor in a VM.
>  
>  I've added some more detailed observations to:
>  
>  https://gitlab.gnome.org/GNOME/mutter/issues/1094 
I've added some debug printk-s the the kernel's vboxvideo driver and discussed
this this with @jadahl on #fedora-desktop on irc.

The problem is the atomic kms API does not have cursor hotspot coordinates. In preparation
for moving to the atomic APIs mutter no longer sets a hotspot for the cursor, instead it
shifts the coordinates where it tells the GPU to draw the cursor by the hotspot's
coordinates.

This does not work with virtual-machines which use so called seamless mouse-mode,
seamless-mode consists of 2 parts:  a) giving absolute coordinates of the mouse to the VM.
b) letting the VM-viewer window-system draw the cursor at those exact coordinates.

Any coordinates the window-system inside the VM passes to the VM for drawing the cursor
are basically totally ignored to avoid lag / flicker (and to not have to grab the cursor
and confine it to the VM-viewer window).

This means that the offset added to the coordinates by mutter to emulate the hotspot are
ignored. For things to work the window-system inside the VM need to pass the VM's
gfx-card the correct hotspot when setting the cursor.

For now the plan is to fix mutter to pass the hot-spot coordinates the old way again.

For the long term we will also need to look at extending the atomic kms API to include
hotspot coordinates support.

Regards,

Hans

[Milan Crha]

On Wed, 2020-03-18 at 12:11 +0100, Olivier Fourdan wrote:
>  I am running GNOME Shell on Wayland on a 1024×768 screen on bare
>  metal (old laptop) on F32 and I cannot reproduce that issue. 
	Hi,
very interesting. I use a virtual machine. I tried to record what I
see, kind of a proof, and the resulting video doesn't show what I see
in the virtual machine. The recorded video has the cursor at the
correct place, while what I see is a shifted cursor.

Does it make any sense?

Again, it does that only with Wayland, X11 is fine.
	Bye,
	Milan