On Thu, Sep 26, 2019 at 04:16:46PM +0200, Fabio Valentini wrote:
> ○ Every commit to dist-git (ie: PR merged) is automatically
built in koji
I don't think this is wise. On the one hand, it will create even more
workload in koji, and on the other hand, running "fedpkg build" for
things I *actually* want to get built is no burden at all. Other steps
in the process dominate.
The motivation for this, as I understand it, is that once a PR is merged
in dist-git, in many cases what we want is to build and create update
without any further ado.
E.g. if I get a PR titled "Update to version N", it'd be nice if the
only thing I would need to do would be to oggle the diff and press one
button.
A mechanism to opt-out would of course be necessary, but automating the
common case would be great and would free packagers to do actually meaningful
stuff.
> ○ Every build in koji results automatically in an update in
bodhi
This might sound like a good idea, but it breaks down when I think about:
- referencing RHBZs,
- specifying update type, severity, reboot/logout, stable/unstable
karma limits, etc.,
- mulit-package updates (this might involve buildroot overrides for
stable releases).
That's all true. I think a package could set defaults through a config file
in dist-git. For example, needs-reboot could be easily handled by this,
since most packages need the same behaviour for every update.
The automation could be smart enough to use some basic rules for other fields,
like: major version bump → enhancement, CVE in %changelog → security update,
etc. An update could also be edited after the fact, for example to bump
severity, if appropriate. We should probably start small, but maybe at
some point we could even make bodhi look into bugzilla and bump the severity
if bugs have high severity set.
I don't think there's a way around manual update creation.
It definitely must stay as an option for the complex cases.
Zbyszek