On 16-01-2023 08:56, Otto Liljalaakso wrote:
> Above change seems like a clear improvement to me, making the most used
> option the default. But I have noticed that workflows differ wildly
> between packagers, so before submitting any code for review, I would
> like to hear if somebody regularly uses the default form 'fedpkg
> scratch-build' and thinks it currently does the right thing.
+1 for the PR.
So far I haven't used the scratch-build command. I always use build,
since I need to supply extra options anyway to start a scratch build
from local HEAD. This change would make me use the scratch-build command
instead.
Since `fedpkg scratch-build` bombs out with an error if you've made local changes I propose a slight modification:
If no changes are made then it does a normal scratch build for the "does this still build / not build" 1% use case
If there are local changes it automatically uploads an SRPM for the 99% use case.
If you end up in a weird state, i.e. made changes but for some reason want to do a "normal" scratch build you have a few different ways to accomplish that.
Thanks,
Richard