On 7 February 2017 at 19:14, Sérgio Basto <sergio(a)serjux.com>
wrote:
>
> On Ter, 2017-02-07 at 18:56 -0500, Stephen John Smoogen wrote:
> >
> > On 7 February 2017 at 18:39, Sérgio Basto <sergio(a)serjux.com>
> > wrote:
> > >
> > >
> > > Hi,
> > > On Ter, 2017-02-07 at 22:32 +0100, Marek Polacek wrote:
> > > >
> > > >
> > > > some C++ FE changes (especially the "Fix type-dependence
> > > > and the current instantiation" changes made the compiler to
> > > > reject
> > > > invalid code
> > > > that had previously been accepted, plus invalid conversions
> > > > with
> > > > '\0'
> > > > are now
> > > > rejected)
> > >
> > > Thanks for exhaustive explanation .
> > > I have this case, how we fix ?
> > > src/rtphint.cpp:342:35: error: ISO C++ forbids comparison
> > > between
> > > pointer and integer [-fpermissive]
> > > if (pSlash != '\0') {
> > >
> >
> > Someone would need to see more code than that. How is pSlash
> > declared?
> > What is the context of the code you have quoted?
>
>
https://github.com/sergiomb2/libmp4v2/blob/master/src/rtphint.cpp#L
> 342
>
> it is package libmp4v2 [1] but I just built it locally , let me
> know if
> you need more information .
>
> [1]
>
https://apps.fedoraproject.org/packages/libmp4v2
>
Thank you for the info. The fix Tom pointed out should be correct
there. The pointer needs to be dereferenced so that the comparison is
'valid'
Fixed :) thanks
--
Sérgio M. B.