On Wed, Jul 25, 2018 at 4:48 AM, Vít Ondruch <vondruch@redhat.com> wrote:

"new-sources" should not be mentioned in basic documentation. These should be added via means of "fedpkg import package.srpm".

The workflow for new package is then:

~~~
$ fedpkg import mypackage.srpm
$ git commit -m "initial import"
~~~

and for updated package:

~~~
$ git add -u
$ fedpkg clog
$ git commit -F clog
$ fedpkg import updated.srpm
$ git commit --am
~~~

This way, the question if the file is stored in lookaside cache or git is done by fedpkg. Also please note that the "import" command removes patches which are not used any longer (not sure if it adds new patches ...).

Thanks. If fedpkg has this capability IMO it should be referenced in the package maintenance guide. I understand that documentation is boring, but if someone makes a change or adds capability to a package, they need to take a few moments to update references to those capabilities in the documentation - especially if that documentation is something as important as the "package maintenance guide". I reference the guide every single time I make changes to packages - just to ensure I'm following the current rules. At least for me, it's vital that these instructions are current and correct.