On 09/12/2016 08:55 PM, Richard W.M. Jones wrote:
On Mon, Sep 12, 2016 at 07:48:31PM +0100, Richard W.M. Jones wrote:
> On Mon, Sep 12, 2016 at 09:06:59AM +0200, Florian Weimer wrote:
>> I had a brief look at the glibc patches. Apparently, off_t and
>> time_t are 32-bit. For a new architecture, that's quite strange.
How do you determine this?
I looked at the patch.
I wrote a simple program which prints sizeof (off_t) and sizeof
inside the RISC-V environment. I *didn't* define
`-D_FILE_OFFSET_BITS=64' when compiling the program. Both values are
printed as 8 (bytes). So it seems we're OK?
Yes, for 64-bit. But the 32-bit parts do not look acceptable as-is.
If you only want the 64-bit architecture, then getting the author to
submit only the 64-bit parts first to glibc upstream would be the
prudent thing to do. (This has to come from the patch author, and the
author has to assign copyright to the FSF.)