On Mon, Jul 20, 2020 at 1:48 PM Neal Gompa <ngompa13@gmail.com> wrote:


Your spec file is a complete mess, so I have not yet touched it to fix it.

Not _my_ spec file. Is this another episode of whinging about %ifdef SUSE, then I suggest you direct your comments at https://github.com/ceph/ceph/blob/master/ceph.spec.in.  I'm sure they will appreciate your usual candor.

Because I'm sure what everyone wants is to maintain two files that are 99% the same. Especially when there are conditionals.
 
Here's an example of how I fixed one package:
https://src.fedoraproject.org/rpms/allegro5/c/2a59aa1daea345823b81c9b396f5766cba54da78

That might actually be helpful.

More constructive comments. Less snark.

--

Kaleb