Dne pá 18. 12. 2020 10:52 dop. uživatel Miro Hrončok <mhroncok@redhat.com> napsal:
On 12/18/20 1:19 AM, clime wrote:
>> I'd very much like to understand the impact of this on the following:
>>
>>
>> 1) Provenpackagers doing mass spec changes/updates.
> If the mass spec change/update doesn't involve an rpkg macro, then
> there is no difference.

I don't understand how there is no difference. The spec "bare" spec file is no
longer there. How do I parse it? How do I grep it? How do I sed it?

But the spec template is there. And the template can be modified. You can grep it and sed it, you cannot directly parse it with rpm without preprocessing it first.


>> 2) Provenpackagers and/or RelEngs doing (targeted) mass rebuilds.
> There should be no impact here. If the source git repo stays the same,
> then the same srpm as for a previous build will be produced.

I don't understand you answer. What does this have to do with "source git repo
stays the same" and "same srpm"? The release must be bumped, they are not the same.

Yes, you are right. I was thinking along the lines of a feature that doesn't exist, which is inserting buildID into built rpms (not srpms) and making that an effective part of the full resulting rpm name.

But there is nothing like that. Sorry for that.

Release needs to be bumped even for soname-bump rebuilds (at least nowadays) so there is an impact if the target package uses git_dir_release preprocessing macro. In that case, bumping is done either by creating a new commit or a new annotated tag (the new tag will also add a new changelog entry and will make the release look nicer). Basically, if releng/ProvenPackager does a rebuild of a package manually, the recommended action currently for such a package is to add a new annotated tag (`fedpkg tag`) and write the reason for the rebuild. If a script is used, that script can be modified to automatically recognize if the target package uses the rpkg macro or not and do the required action for bumping accordingly. This is kind of a logic that should land in rpmdev-bumpspec. 

If this seems inconvenient, we can further discuss the options. We could e.g. make it so that just creating a new empty commit would be enough instead of tagging.


Thanks for the other answers.

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org