-Wno-format vs. -Werror=format-security
Hi!
As you might know, redhat-rpm-config is adding -Wall -Werror=format-security
into $RPM_OPT_FLAGS/%{optflags} by default.
I've recently fixed a bug #1425825 where -Wall -Werror=format-security -Wall
or -Wall -Werror=format-security -Wformat etc. actually disabled the
-Wformat-security warning (unlike -Wall -Wformat-security -Wall etc. that
behaved as intended before).
Now, this change might have a consequence on some packages, in particular
e.g. if you append -Wno-format to the standard optflags in some Makefile,
you might get errors because -Wno-format doesn't disable the explicitly
specified suboptions like -Wformat-security and having -Wformat-security
enabled and -Wno-format is an error. The fix is if you really need
to add -Wno-format, also add -Wno-format-security to cancel the default
-Werror=format-security provided by redhat-rpm-config.
Jakub