Hi,
On 31-05-18 15:20, Robert Marcano wrote:
On 05/31/2018 06:52 AM, Hans de Goede wrote:
> ...
> This will basically get us back the F28 behavior of showing the
> menu but only after a failed boot, I think that is a good
> solution, do you agree?
What is the definition of a successful boot? I ask because a machine could boot
perfectly, and when you try to interact with it on the login screen, bugs on the display
driver can change the screen to garbage (I have seen this kind on bug long time ago), or
lockup. So, the user will be unable to activate any kind of restart with menu enabled in
order to try an older kernel, or boot to rescue mode.
I think instead of only detecting a successful boot, a machine that wasn't properly
shutdown should enable the menu
A broken install may still shutdown properly after the using pressing the power-button
and/or
trying ctrl+alt+del.
But this is an interesting suggestion, I think we should track both separately,
so successful shutdown and successful boot and show the menu if either one is
not true. That should make the chance of not being able to get the menu a lot
smaller.
Regards,
Hans