On 3/9/19 7:33 PM, Chris wrote:
> Thank you both for your fast reply!
>
>  >  Why do you need to BuildRequire a linting tool? What are you trying
> to achieve?
>
> I just use python-flake8 as an OCD way of having my build fail if i fail
> pep8 :)  It's just used in conjunction of my unit tests.

Running a linter is fine upstream, but I'll argue that you'll be much
better off disabling it for the distro build.

Newer versions of flake8 can cause your tests to suddenly fail. We've
seen that happen relatively often -- style standards themselves evolve,
and the way they're codified in automatic tools evolves.

Upstream, please do check code style or unused imports if that's your
thing. But after you cut a release (on GitHub/PyPI), linting the code
doesn't really bring any benefit. (Unlike running the test suite, of
course.)

Even if you're currently maintaining this both upstream and in Fedora,
and have the energy to watch for & fix any failures, after some years
you might want to pass the package on to someone else. Be nice to your
successor. And be nice your potential Debian (et al.) maintainers by
making your specfile show how to package for a distro :)


(Note: AFAIK this is not official Fedora policy; please
disagree/discuss/argue.)
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org