On Tue, Jan 21, 2014 at 11:25 AM, Alec Leamas <leamas.alec@gmail.com> wrote:

Actually, the GL are pretty clear here: the source should be referenced using the full commit, nothing else. There is some reasoning why. The tag should got to Version: (as long its 'sane').

Besides that this is the existing GL, there is also a subtle difference in git-archive (which supposedly runs this). When archiving a tag, the sources gets today's date. OTOH, when archiving a commit, the sources modification dates are their commit date. Last time I checked this was also true on github.

Of course github could change it at any time but it looks to be working properly right now, in the case of OpenColorIO:

Source0: https://github.com/%{upstream}/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz

run through spectool:

https://github.com/imageworks/OpenColorIO/archive/v1.0.9/OpenColorIO-1.0.9.tar.gz

downloaded right now:

$ curl -LO https://github.com/imageworks/OpenColorIO/archive/v1.0.9/OpenColorIO-1.0.9.tar.gz

$ ll OpenColorIO-1.0.9

total 72

-rw-rw-r--. 1 build build 11958 Oct 8 17:59 ChangeLog

-rw-rw-r--. 1 build build 15763 Oct 8 17:59 CMakeLists.txt

drwxrwxr-x. 6 build build 4096 Oct 8 17:59 docs

drwxrwxr-x. 5 build build 4096 Oct 8 17:59 export

drwxrwxr-x. 3 build build 4096 Oct 8 17:59 ext

-rw-rw-r--. 1 build build 45 Oct 8 17:59 INSTALL

-rw-rw-r--. 1 build build 11286 Oct 8 17:59 LICENSE

-rw-rw-r--. 1 build build 1115 Oct 8 17:59 README

drwxrwxr-x. 6 build build 4096 Oct 8 17:59 share

drwxrwxr-x. 11 build build 4096 Oct 8 17:59 src

drwxrwxr-x. 2 build build 4096 Oct 8 17:59 testdata

Still has the Oct 8 tag date.

Is there a possibility of updating the guidelines? I like this method much better, no only is it clearer but easier to maintain. Of course if upstream does not tag releases, then the current method should be used.

Thanks,

Richard