On Tue, May 5, 2020 at 6:16 PM Miro Hrončok mhroncok@redhat.com wrote:
In what way does keeping the spec file in our fork help us?
(speechless for like a minute)
I don't really understand this comment. Speechless because our workflow is tedious?
I just couldn't understand why you are asking me about source-git when you already track your downstream patches as git commits :D
Don't you wanna create (S)RPMs out of that repository? Don't you wanna be sure that when you add a change to that repository it builds fine on rawhide and the latest stable fedora?
That would be cool. I don't understand why do I have to keep the spec file in there for that.
You don't.
With these ~20 lines you can get RPM builds for every PR in chroots of your choice:
https://github.com/TomasTomecek/cpython/pull/1
(the build is failing, even SRPM can't be created, seems like there is a file in the repo which can't be processed by tar & gzip, need to take a closer look)
The spec file is being fetched from rawhide's dist-git for every build. Your use case is a little bit more complex since you patch conditionally so we'd probably need a mechanism in packit: 1. not to add 'Patch: 0001...' lines into spec 2. not touch %setup line 3. and map respective git commits to Patch lines within a spec
so that all would work well for your use case - there are also different ways how to solve it but that would be a lot of typing
Tomas