Dne 24.7.2018 v 22:24 Gerald B. Cox napsal(a):
On Tue, Jul 24, 2018 at 10:07 AM, Artur Iwicki <suve@fedoraproject.org> wrote:
That section of the guide is a bit poorly worded. You should *not* use "git add" on source tarballs. These should be added only via means of "fedpkg new-sources $FILES; git add ./sources".

"new-sources" should not be mentioned in basic documentation. These should be added via means of "fedpkg import package.srpm".

The workflow for new package is then:

~~~
$ fedpkg import mypackage.srpm
$ git commit -m "initial import"
~~~

and for updated package:

~~~
$ git add -u
$ fedpkg clog
$ git commit -F clog
$ fedpkg import updated.srpm
$ git commit --am
~~~

This way, the question if the file is stored in lookaside cache or git is done by fedpkg. Also please note that the "import" command removes patches which are not used any longer (not sure if it adds new patches ...).


V.

I believe what the guide means under "new source files" is e.g. when upstream does not provide an icon or a .desktop or an .appdata.xml file (or a systemd .service or whatever) and you add your own. This does not include "new upstream release tarball".

I'll try to think of some way to make that more clear and submit a suggestion to change the guide text.

Thanks for the clarification and taking the initiative to get it fixed.  As far as "poorly worded", that's a candidate
for understatement of the day... LOL

It uses the exact same wording - "new source files" in both statements with absolutely no differentiation:

- Stage any small patches or new source files for commit:
- Upload new source files to the lookaside cache:





_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/7P6XXOEE3KFBWLP2DPEIBNTVZ54CGPNJ/