On 20. 12. 21 21:39, Florian Weimer wrote:
> * Ben Cotton:
>
>> This change will be implemented by updating the %__spec_build_pre and
>> %__speck_check_pre macros in redhat-rpm-config to include
>> %set_build_flags. This will set these environment variables
>> automatically before the %build and %check sections. See the proposed
>>
[
https://src.fedoraproject.org/fork/tstellar/rpms/redhat-rpm-config/c/a397...
>> implementation] for more details.
> Would you please add a clear opt-out mechanism, and document the
> behavior and the mechanism in buildflags.md?
> I can't tell right now how much is going to break because of this,
> but I
> think it's worth a try.
I suppose the obvious opt-out mechanism is to call unset on the
CFLAGS, LDFLAGS etc. Shell variables, no?
We might introduce further variables in the future, so I'd prefer an
explicit mechanism. We added LT_SYS_LIBRARY_PATH fairly recently, for
example.
Thanks,
Florian