Review request: selenium-geckodriver

[Thomas Andrejak]

Hello

Here is the review request:
https://bugzilla.redhat.com/show_bug.cgi?id=1771769

I need this package to control selenium. Can someone review it ? it is a
simple package.

Thanks !

Regards

Thomas

[Leigh Scott]

I wouldn't review this as it isn't correct to use prebuilt code, you will need to
build from source.

Source0:      
https://github.com/mozilla/geckodriver/releases/download/v0.26.0/geckodri...

[Luya Tshimbalanga]

Hello Thomas,

I will take your review in exchange of mine below:

https://bugzilla.redhat.com/show_bug.cgi?id=1771173

Would you update yours following the feedback?


-- 
Luya Tshimbalanga
Fedora Design Team
Fedora Design Suite maintainer

[Kevin Kofler]

Luya Tshimbalanga wrote:
>  I will take your review in exchange of mine below: 
Unfortunately, I doubt that Thomas has sufficient packaging experience to do 
a review swap. Packaging binary blobs as he did is a complete no go in 
Fedora, everything must be built from source.

        Kevin Kofler

[Jared K. Smith]

On Wed, Nov 20, 2019 at 7:18 AM Kevin Kofler <kevin.kofler(a)chello.at&gt; wrote:

>  Unfortunately, I doubt that Thomas has sufficient packaging
> experience to
>  do
>  a review swap.
>  
One of the things we should always strive for in Fedora is to assume
positive intent.  In this situation, that would mean assuming it was an
accident, rather than ascribing it to anything else. We want Fedora to be a
welcoming place, and comments like this don't help.

-Jared