7 a.m.
Hey all,
Nearly four years and *754 commits* since rpmlint 1.10, we are
releasing rpmlint 2.0.0!
This new release has a _lot_ of new features, but here are the most notable:
* RPMLint now is a "normal" Python application and now supports being
imported like a standard Python module! This means that all the normal
use-cases for RPMLint are still supported, but now you can make it a
part of larger Python-based applications or services.
* RPMLint uses a declarative TOML-based syntax for configuring RPMLint
policy instead of Python code.
* RPMLint now has an override system for the descriptions shown for
various checks, so that distributions who want to give specific policy
information can do so without patching the code.
* RPMLint includes _many more checks_! Nearly all of the generally
useful checks created by the openSUSE community have been merged into
the tree, so distributions can now benefit from a wider offering of
checks to implement policy enforcement.
* RPMLint is Python 3 only and now supports Python 3.6 and newer.
* RPMLint is now built and installed like a standard Python
application using setuptools.
I want to specifically thank Tomáš Chvátal, Martin Liska, Kristyna
Streitova, Dirk Mueller, Miroslav Suchý, Ondřej Súkup, thisisshub, and
Miro Hrončok as top contributors to make this release happen!
Full author list with number of commits:
309 Tomáš Chvátal
197 Martin Liska
47 Dirk Mueller
26 Kristyna Streitova
24 Neal Gompa (ニール・ゴンパ)
24 marxin
21 Neal Gompa
21 Ondřej Súkup
14 thisisshub
11 Miro Hrončok
9 Kristýna Streitová
8 Miroslav Suchý
6 Markéta Calábková
5 Ville Skyttä
4 Ben Greiner
4 Frank Schreiner
4 Van de Bugger
3 David Greaves
3 Matwey V. Kornilov
2 Daniel Mach
2 Matthias Gerstner
1 Cathy Hu
1 Ludwig Nussel
1 MeggyCal
1 Petr Menšík
1 Stefan Brüns
1 Steve Kowalik
1 Werner Fink
1 Wolfgang Stöggl
1 Yanko Kaneti
1 tpgxyz
--
真実はいつも一つ！/ Always, there's only one truth!
7:07 a.m.
On Tue, May 18, 2021 at 8:00 AM Neal Gompa <ngompa13(a)gmail.com> wrote:
Hey all,
Nearly four years and *754 commits* since rpmlint 1.10, we are
releasing rpmlint 2.0.0!
Oh whoops, I forgot to include the release URL:
https://github.com/rpm-software-management/rpmlint/releases/tag/2.0.0
--
真実はいつも一つ！/ Always, there's only one truth!
7:09 a.m.
On 18. 05. 21 14:00, Neal Gompa wrote:
Hey all,
Nearly four years and *754 commits* since rpmlint 1.10, we are
releasing rpmlint 2.0.0!
This new release has a _lot_ of new features, but here are the most notable:
* RPMLint now is a "normal" Python application and now supports being
imported like a standard Python module! This means that all the normal
use-cases for RPMLint are still supported, but now you can make it a
part of larger Python-based applications or services.
* RPMLint uses a declarative TOML-based syntax for configuring RPMLint
policy instead of Python code.
* RPMLint now has an override system for the descriptions shown for
various checks, so that distributions who want to give specific policy
information can do so without patching the code.
* RPMLint includes _many more checks_! Nearly all of the generally
useful checks created by the openSUSE community have been merged into
the tree, so distributions can now benefit from a wider offering of
checks to implement policy enforcement.
* RPMLint is Python 3 only and now supports Python 3.6 and newer.
* RPMLint is now built and installed like a standard Python
application using setuptools.
Awesome! What is the plan for Fedora? Shall we migrate to rpmlint 2 in
rawhide? I recall Mirek Suchý had some WIP Fedora config.
I want to specifically thank Tomáš Chvátal, Martin Liska, Kristyna
Streitova, Dirk Mueller, Miroslav Suchý, Ondřej Súkup, thisisshub, and
Miro Hrončok as top contributors to make this release happen!
I've barely made it :D
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
7:13 a.m.
On Tue, May 18, 2021 at 8:10 AM Miro Hrončok <mhroncok(a)redhat.com> wrote:
On 18. 05. 21 14:00, Neal Gompa wrote:
> Hey all,
>
> Nearly four years and *754 commits* since rpmlint 1.10, we are
> releasing rpmlint 2.0.0!
>
> This new release has a _lot_ of new features, but here are the most notable:
>
> * RPMLint now is a "normal" Python application and now supports being
> imported like a standard Python module! This means that all the normal
> use-cases for RPMLint are still supported, but now you can make it a
> part of larger Python-based applications or services.
> * RPMLint uses a declarative TOML-based syntax for configuring RPMLint
> policy instead of Python code.
> * RPMLint now has an override system for the descriptions shown for
> various checks, so that distributions who want to give specific policy
> information can do so without patching the code.
> * RPMLint includes _many more checks_! Nearly all of the generally
> useful checks created by the openSUSE community have been merged into
> the tree, so distributions can now benefit from a wider offering of
> checks to implement policy enforcement.
> * RPMLint is Python 3 only and now supports Python 3.6 and newer.
> * RPMLint is now built and installed like a standard Python
> application using setuptools.
Awesome! What is the plan for Fedora? Shall we migrate to rpmlint 2 in
rawhide? I recall Mirek Suchý had some WIP Fedora config.
Yes, please! The new rpmlint is *way* better than what we have now,
and the rpmlint-1.x branch is basically dead now. Nobody is working on
that codebase anymore.
Someone please do it, pretty please! 🙏
> I want to specifically thank Tomáš Chvátal, Martin Liska,
Kristyna
> Streitova, Dirk Mueller, Miroslav Suchý, Ondřej Súkup, thisisshub, and
> Miro Hrončok as top contributors to make this release happen!
I've barely made it :D
But you did, and that's what matters! :)
--
真実はいつも一つ！/ Always, there's only one truth!
10:05 a.m.
On 5/18/21 8:13 AM, Neal Gompa wrote:
On Tue, May 18, 2021 at 8:10 AM Miro Hrončok
<mhroncok(a)redhat.com> wrote:
> Awesome! What is the plan for Fedora? Shall we migrate to rpmlint 2 in
> rawhide? I recall Mirek Suchý had some WIP Fedora config.
>
Yes, please! The new rpmlint is *way* better than what we have now,
and the rpmlint-1.x branch is basically dead now. Nobody is working on
that codebase anymore.
Someone please do it, pretty please! 🙏
If that's the case, it might not be a bad idea to push the new version
in the stable releases, too, no?
--
Susi Lehtola
Fedora Project Contributor
jussilehtola(a)fedoraproject.org
11:28 a.m.
Dne 18. 05. 21 v 17:05 Susi Lehtola napsal(a):
On 5/18/21 8:13 AM, Neal Gompa wrote:
> On Tue, May 18, 2021 at 8:10 AM Miro Hrončok <mhroncok(a)redhat.com> wrote:
>> Awesome! What is the plan for Fedora? Shall we migrate to rpmlint 2 in
>> rawhide? I recall Mirek Suchý had some WIP Fedora config.
https://github.com/rpm-software-management/rpmlint/tree/main/configs/Fedora
there are still some FIXME, some things which are commented out and we should decide
whether we want them or not.
> Yes, please! The new rpmlint is *way* better than what we have
now,
> and the rpmlint-1.x branch is basically dead now. Nobody is working on
> that codebase anymore.
True. But...
> If that's the case, it might not be a bad idea to push the
new version
> in the stable releases, too, no?
The new rpmlint is different. Better, but different. Going through rawhide only is
better.
It would be great if somebody provided Copr project for stable release.
Miroslav
11:46 p.m.
This sounds terrific !
I too can't wait till Fedora adopts it.
* RPMLint includes _many more checks_! Nearly all of the generally
However I always have a hard time understanding what the issue caught
by RPMLint actually is.
I would like to see some library of the checks with the explanation of
what it is, why it is important and usual examples of bad / correct
code and how to fix it. Something like CWEs (e.g. [1])
Is there something like it already by any chance ?
There is a long way between an error / warning being reported by
RPMLint with maintainer just ignoring it, and the maintainer to
understand the value and importance of having it fixed (as well as
knowledge how to fix it)
[1] https://cwe.mitre.org/data/definitions/416.html
--
Michal Schorm
Software Engineer
Core Services - Databases Team
Red Hat
--
On Tue, May 18, 2021 at 2:01 PM Neal Gompa <ngompa13(a)gmail.com> wrote:
>
> Hey all,
>
> Nearly four years and *754 commits* since rpmlint 1.10, we are
> releasing rpmlint 2.0.0!
>
> This new release has a _lot_ of new features, but here are the most notable:
>
> * RPMLint now is a "normal" Python application and now supports being
> imported like a standard Python module! This means that all the normal
> use-cases for RPMLint are still supported, but now you can make it a
> part of larger Python-based applications or services.
> * RPMLint uses a declarative TOML-based syntax for configuring RPMLint
> policy instead of Python code.
> * RPMLint now has an override system for the descriptions shown for
> various checks, so that distributions who want to give specific policy
> information can do so without patching the code.
* RPMLint includes _many more checks_! Nearly all of the generally
> useful checks created by the openSUSE community have been merged into
> the tree, so distributions can now benefit from a wider offering of
> checks to implement policy enforcement.
> * RPMLint is Python 3 only and now supports Python 3.6 and newer.
> * RPMLint is now built and installed like a standard Python
> application using setuptools.
>
> I want to specifically thank Tomáš Chvátal, Martin Liska, Kristyna
> Streitova, Dirk Mueller, Miroslav Suchý, Ondřej Súkup, thisisshub, and
> Miro Hrončok as top contributors to make this release happen!
>
> Full author list with number of commits:
>
> 309 Tomáš Chvátal
> 197 Martin Liska
> 47 Dirk Mueller
> 26 Kristyna Streitova
> 24 Neal Gompa (ニール・ゴンパ)
> 24 marxin
> 21 Neal Gompa
> 21 Ondřej Súkup
> 14 thisisshub
> 11 Miro Hrončok
> 9 Kristýna Streitová
> 8 Miroslav Suchý
> 6 Markéta Calábková
> 5 Ville Skyttä
> 4 Ben Greiner
> 4 Frank Schreiner
> 4 Van de Bugger
> 3 David Greaves
> 3 Matwey V. Kornilov
> 2 Daniel Mach
> 2 Matthias Gerstner
> 1 Cathy Hu
> 1 Ludwig Nussel
> 1 MeggyCal
> 1 Petr Menšík
> 1 Stefan Brüns
> 1 Steve Kowalik
> 1 Werner Fink
> 1 Wolfgang Stöggl
> 1 Yanko Kaneti
> 1 tpgxyz
>
> --
> 真実はいつも一つ！/ Always, there's only one truth!
> _______________________________________________
> devel mailing list -- devel(a)lists.fedoraproject.org
> To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
5:54 a.m.
Dne 19. 05. 21 v 6:46 Michal Schorm napsal(a):
> * RPMLint includes_many more checks_! Nearly all of the
generally
However I always have a hard time understanding what the issue caught
by RPMLint actually is.
I would like to see some library of the checks with the explanation of
what it is, why it is important and usual examples of bad / correct
code and how to fix it. Something like CWEs (e.g. [1])
Is there something like it already by any chance ?
There is a long way between an error / warning being reported by
RPMLint with maintainer just ignoring it, and the maintainer to
understand the value and importance of having it fixed (as well as
knowledge how to fix it)
[1]https://cwe.mitre.org/data/definitions/416.html
$ python3 lint.py /tmp/tito/rpmconf-1.1.4-1.fc34.src.rpm
...
rpmconf.src: E: description-line-too-long This tool search ...
$ python3 lint.py -e description-line-too-long
description-line-too-long:
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines
Or you can run rpmlint in verbose mode "-v" where this explanation is printed
for every findings.
Is this good enough? ;)
Miroslav
2:51 p.m.
I have landed rpmlint 2.0.0 in rawhide, along with Mirek Suchý's toml
configs (with updates for the licenses.toml). PRs, bug reports, and
suggestions welcome.
Thanks,
~spot
On Wed, May 19, 2021 at 6:55 AM Miroslav Suchý <msuchy(a)redhat.com> wrote:
Dne 19. 05. 21 v 6:46 Michal Schorm napsal(a):
* RPMLint includes _many more checks_! Nearly all of the generally
However I always have a hard time understanding what the issue caught
by RPMLint actually is.
I would like to see some library of the checks with the explanation of
what it is, why it is important and usual examples of bad / correct
code and how to fix it. Something like CWEs (e.g. [1])
Is there something like it already by any chance ?
There is a long way between an error / warning being reported by
RPMLint with maintainer just ignoring it, and the maintainer to
understand the value and importance of having it fixed (as well as
knowledge how to fix it)
[1] https://cwe.mitre.org/data/definitions/416.html
$ python3 lint.py /tmp/tito/rpmconf-1.1.4-1.fc34.src.rpm
...
rpmconf.src: E: description-line-too-long This tool search ...
$ python3 lint.py -e description-line-too-long
description-line-too-long:
Your description lines must not exceed 79 characters. If a line is
exceeding
this number, cut it to fit in two lines
Or you can run rpmlint in verbose mode "-v" where this explanation is
printed for every findings.
Is this good enough? ;)
Miroslav
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
2:53 p.m.
On Thu, Jun 3, 2021 at 3:52 PM Tom Callaway <spotrh(a)gmail.com> wrote:
I have landed rpmlint 2.0.0 in rawhide, along with Mirek Suchý's toml configs (with
updates for the licenses.toml). PRs, bug reports, and suggestions welcome.
Thank you so much, Tom!
--
真実はいつも一つ！/ Always, there's only one truth!
1:21 a.m.
V Thu, Jun 03, 2021 at 03:51:59PM -0400, Tom Callaway napsal(a):
I have landed rpmlint 2.0.0 in rawhide, along with Mirek Suchý's
toml
configs (with updates for the licenses.toml). PRs, bug reports, and
suggestions welcome.
It breaks "fedpkg lint"
<https://bugzilla.redhat.com/show_bug.cgi?id=1967821>
and plain "rpmlint foo.spec" does not work either
<https://bugzilla.redhat.com/show_bug.cgi?id=1967822>;.
-- Petr
9:25 a.m.
On Thu, Jun 03, 2021 at 03:51:59PM -0400, Tom Callaway wrote:
I have landed rpmlint 2.0.0 in rawhide, along with Mirek Suchý's
toml
configs (with updates for the licenses.toml). PRs, bug reports, and
suggestions welcome.
Thanks for doing this!
I gave it a go:
systemd.spec: E: specfile-error rpm: /usr/bin/rpmspec: No such file
or directory
→ seems to be missing some dep?
rpmlint: 2.0.0
configuration:
/usr/lib/python3.9/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
→ can we please please move all those files under /usr somewhere? Those are packaged
files that users should never modify locally (they should add per-package overrides
instead…).
$ rpmlint -i systemd
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
Traceback (most recent call last):
File "/usr/bin/rpmlint", line 33, in <module>
sys.exit(load_entry_point('rpmlint==2.0.0', 'console_scripts',
'rpmlint')())
File "/usr/lib/python3.9/site-packages/rpmlint/cli.py", line 174, in lint
sys.exit(lint.run())
File "/usr/lib/python3.9/site-packages/rpmlint/lint.py", line 100, in run
return self._run()
File "/usr/lib/python3.9/site-packages/rpmlint/lint.py", line 69, in _run
self.validate_installed_packages(self._load_installed_rpms(self.options['installed']))
File "/usr/lib/python3.9/site-packages/rpmlint/lint.py", line 205, in
validate_installed_packages
self.run_checks(pkg)
File "/usr/lib/python3.9/site-packages/rpmlint/lint.py", line 258, in
run_checks
fn(pkg)
File "/usr/lib/python3.9/site-packages/rpmlint/checks/TmpFilesCheck.py", line
34, in check
self._check_tmpfile_in_filelist(pkgfile, pkg)
File "/usr/lib/python3.9/site-packages/rpmlint/checks/TmpFilesCheck.py", line
79, in _check_tmpfile_in_filelist
with open(pkgfile.path) as inputf:
FileNotFoundError: [Errno 2] No such file or directory:
'/tmp/rpmlint.systemd.uqz1l_h2/usr/lib/tmpfiles.d/README'
→ I'm not sure what's going on here. /usr/lib/tmpfiles.d/README exists.
Zbyszek
3:35 p.m.
FileNotFoundError: [Errno 2] No such file or directory:
'/tmp/rpmlint.systemd.uqz1l_h2/usr/lib/tmpfiles.d/README'
→ I'm not sure what's going on here. /usr/lib/tmpfiles.d/README exists.
I think the line
https://github.com/rpm-software-management/rpmlint/blob/2402248b1a2f4c770...
("dirname = dirname if dirname != '/' else None")
should be replaced with such a code:
if dirname == '/':
return dirname
1:16 a.m.
On 03. 06. 21 21:51, Tom Callaway wrote:
I have landed rpmlint 2.0.0 in rawhide, along with Mirek Suchý's
toml configs
(with updates for the licenses.toml). PRs, bug reports, and suggestions welcome.
Thanks, spot!
I'm looking at the stuck Python 3.10 rebuild due to the s390x builder outage:
https://koji.fedoraproject.org/koji/taskinfo?taskID=69342995
And I wonder whether the package should be noarch? Do you recall why it is not?
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
9:20 a.m.
Miro Hrončok wrote:
On 03. 06. 21 21:51, Tom Callaway wrote:
> I have landed rpmlint 2.0.0 in rawhide, along with Mirek Suchý's toml
> configs (with updates for the licenses.toml). PRs, bug reports, and
> suggestions welcome.
Thanks, spot!
I'm looking at the stuck Python 3.10 rebuild due to the s390x builder outage:
https://koji.fedoraproject.org/koji/taskinfo?taskID=69342995
And I wonder whether the package should be noarch? Do you recall why it is not?
The build above is rmlint (no 'p') -- it took me a minute to
two to notice that. The rpmlint package is noarch.
This appears to be the rpmlint build in the f35-python side
tag:
https://koji.fedoraproject.org/koji/taskinfo?taskID=69362379
That build did fail too:
DEBUG util.py:444: Error:
DEBUG util.py:444: Problem 1: conflicting requests
DEBUG util.py:444: - nothing provides python(abi) = 3.9 needed by
python3-pytest-flake8-1.0.6-3.fc34.noarch
DEBUG util.py:444: - nothing provides python3.9dist(pytest) >= 3.5 needed by
python3-pytest-flake8-1.0.6-3.fc34.noarch
DEBUG util.py:444: Problem 2: conflicting requests
DEBUG util.py:444: - nothing provides python(abi) = 3.9 needed by
python3-zstd-1.4.5.1-3.fc34.i686
It looks like that's due to building rpmlint before all of
its build deps were rebuilt for python 3.10?
--
Todd
4:46 p.m.
On 05. 06. 21 16:20, Todd Zullinger wrote:
Miro Hrončok wrote:
> On 03. 06. 21 21:51, Tom Callaway wrote:
>> I have landed rpmlint 2.0.0 in rawhide, along with Mirek Suchý's toml
>> configs (with updates for the licenses.toml). PRs, bug reports, and
>> suggestions welcome.
>
> Thanks, spot!
>
> I'm looking at the stuck Python 3.10 rebuild due to the s390x builder outage:
>
> https://koji.fedoraproject.org/koji/taskinfo?taskID=69342995
>
> And I wonder whether the package should be noarch? Do you recall why it is not?
The build above is rmlint (no 'p') -- it took me a minute to
two to notice that. The rpmlint package is noarch.
Oh my. This has been a long week. Sorry for the noise :D
This appears to be the rpmlint build in the f35-python side
tag:
https://koji.fedoraproject.org/koji/taskinfo?taskID=69362379
That build did fail too:
DEBUG util.py:444: Error:
DEBUG util.py:444: Problem 1: conflicting requests
DEBUG util.py:444: - nothing provides python(abi) = 3.9 needed by
python3-pytest-flake8-1.0.6-3.fc34.noarch
DEBUG util.py:444: - nothing provides python3.9dist(pytest) >= 3.5 needed by
python3-pytest-flake8-1.0.6-3.fc34.noarch
DEBUG util.py:444: Problem 2: conflicting requests
DEBUG util.py:444: - nothing provides python(abi) = 3.9 needed by
python3-zstd-1.4.5.1-3.fc34.i686
It looks like that's due to building rpmlint before all of
its build deps were rebuilt for python 3.10?
Yep, after building the initial 550 "important" packages, we use brute force.
Unfortunately, the s390x builder outage currently prevents more (reasonable)
rebuild rounds, so we'll continue after it ends.
Nevertheless, rpmlint Python 3.10 rebuild is probably blocked on:
https://bugzilla.redhat.com/show_bug.cgi?id=1899866
I've also opened https://src.fedoraproject.org/rpms/rpmlint/pull-request/17 to
drop the dependency on pytest-flake8.
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
1049
days inactive
1067
days old
15 comments
10 participants
participants (10)
-
Michal Schorm -
Miro Hrončok -
Miroslav Suchý -
Neal Gompa -
Paweł Marciniak -
Petr Pisar -
Susi Lehtola -
Todd Zullinger -
Tom Callaway -
Zbigniew Jędrzejewski-Szmek