RFE: fedpkgdiff?

[Richard Shaw]

I'm curious to see if anyone else would find this useful...

What about a fedpkgdiff as a wrapper around pkgdiff (similar to
fedabipkgdiff) but just to see the difference between two packages (either
local or from the repos like fedabipkgdiff), specifically differences in:

- installed files (not contents)
- requires
- provides

Thoughts?

Thanks,
Richard

[Miro Hrončok]

On 15. 02. 19 22:54, Richard Shaw wrote:
>  I'm curious to see if anyone else would find this useful...
>  
>  What about a fedpkgdiff as a wrapper around pkgdiff (similar to fedabipkgdiff) 
>  but just to see the difference between two packages (either local or from the 
>  repos like fedabipkgdiff), specifically differences in:
>  
>  - installed files (not contents)
>  - requires
>  - provides 
obsoletes, conflicts, etc... simply - metadata

>  
>  Thoughts? 
I would actually love to see this information in a src.fp.o Pull Requests. 
Posted by some bot.

-- 
Miro Hrončok
--
Phone: [phone]
IRC: mhroncok

[Fabio Valentini]

On Fri, Feb 15, 2019, 22:55 Richard Shaw <hobbes1069(a)gmail.com wrote:

>  I'm curious to see if anyone else would find this useful...
>
>  What about a fedpkgdiff as a wrapper around pkgdiff (similar to
>  fedabipkgdiff) but just to see the difference between two packages (either
>  local or from the repos like fedabipkgdiff), specifically differences in:
>
>  - installed files (not contents)
>  - requires
>  - provides
>  
Either I don't understand the question, or you missed something obvious...
Isn't that what rpmdiff does already (for local .rpm files)?

Fabio


>  Thoughts?
>
>  Thanks,
>  Richard
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]
>

[Richard Shaw]

On Fri, Feb 15, 2019 at 4:09 PM Fabio Valentini <decathorpe(a)gmail.com&gt;
wrote:

>  On Fri, Feb 15, 2019, 22:55 Richard Shaw <hobbes1069(a)gmail.com
> wrote:
>
> > I'm curious to see if anyone else would find this useful...
> >
> > What about a fedpkgdiff as a wrapper around pkgdiff (similar to
> > fedabipkgdiff) but just to see the difference between two packages (either
> > local or from the repos like fedabipkgdiff), specifically differences in:
> >
> > - installed files (not contents)
> > - requires
> > - provides
> >
>
>  Either I don't understand the question, or you missed something obvious...
>  Isn't that what rpmdiff does already (for local .rpm files)?
>  
Yes, it would work similar to abipkgdiff, the difference is in the wrapper,
fed<command> which would wrap it in something that improves packager
quality of life...

So in the case of all the FTBFS packages I'm working on instead of having
to manually download packages to some temporary directory from koji or dnf
command I could just do a "fedpkg mockbuild" on my proposed fix and then
"fedpkgdiff /path/to/new/package --dist fc30" and let it do all the other
steps for me, thus saving me a not insignificant amount of work/time which
I don't have a lot of since packaging isn't my dayjob.

Thanks,
Richard

[Ondřej Lysoněk]

On 15. 02. 19 23:19, Richard Shaw wrote:
>  So in the case of all the FTBFS packages I'm working on instead
> of
>  having to manually download packages to some temporary directory from
>  koji or dnf command I could just do a "fedpkg mockbuild" on my proposed
>  fix and then "fedpkgdiff /path/to/new/package --dist fc30" and let it do
>  all the other steps for me, thus saving me a not insignificant amount of
>  work/time which I don't have a lot of since packaging isn't my dayjob. 
This would be really great. It's tedious to do it manually.

Ondřej Lysoněk

[Richard Shaw]

Out of curiosity I took a look at abipkgdiff that's provided by the
libabigail package and it's a python wrapper around abipkgdiff. I'm a
little rusty on Python but I could probably use that as a very nice
starting point...

The next question is what package would the wrapper go in? I think the
natural place is fedora-packager.

Thanks,
Richard

[Todd Zullinger]

Hi,

Richard Shaw wrote:
>  Out of curiosity I took a look at abipkgdiff that's provided by
> the
>  libabigail package and it's a python wrapper around abipkgdiff. I'm a
>  little rusty on Python but I could probably use that as a very nice
>  starting point...
>  
>  The next question is what package would the wrapper go in? I think the
>  natural place is fedora-packager. 
That or integrate it into rpkg/fedpkg as a subcommand if
you're writing it in python anyway.

If you decide to propose it for inclusion in fedora-packager
(or anything other than as an rpkg/fedpkg subcommand), may I
suggest that the command name use some prefix other than
than fedpkg-, to avoid extra typing when tab completing
fedpkg commands?  If it's in fedora-packager, fedora- would
probably be a reasonable prefix.

Thanks, and happy hacking,

-- 
Todd