Disable LTO for now ?

Hello opencv [1] build also failed around LTO
What is your advise ? What is your advice?

Thanks,

[1]
https://koji.fedoraproject.org/koji/taskinfo?taskID=48054416


On 2020-07-27 23:46, notifications(a)fedoraproject.org wrote:
> Notification time stamped 2020-07-27 22:46:34 UTC
> 
> From f4bac7efd3c251ffb64107bc2f522c1d3c829b5c Mon Sep 17 00:00:00 2001
> From: Jeff Law <law(a)redhat.com&gt;
> Date: Jul 27 2020 22:46:22 +0000
> Subject: Disable LTO for now
> 
> 
> ---
> 
> diff --git a/apt.spec b/apt.spec
> index a555b62..282ddc8 100644
> --- a/apt.spec
> +++ b/apt.spec
> @@ -14,7 +14,7 @@
> 
>  Name:           apt
>  Version:        2.1.7
> -Release:        2%{?dist}
> +Release:        3%{?dist}
>  Summary:        Command-line package manager for Debian packages
> 
>  License:        GPLv2+
> @@ -166,6 +166,10 @@ to package management with APT.
>  %autosetup -p1
> 
>  %build
> +# This package fails its testsuite when LTO is enabled.  It is not yet 
> clear if
> +# this is an LTO issue or an issue with the package itself
> +%define _lto_cflags %{nil}
> +
>  %cmake -GNinja
>  %cmake_build
> 
> @@ -308,6 +312,9 @@ exit 0
>  %doc %{_docdir}/%{name}-utils
> 
>  %changelog
> +* Mon Jul 27 2020 Jeff law <law(a)redhat.com.com&gt; - 2.1.7-3
> +- Disable LTO for now
> +
>  * Mon Jul 27 2020 Fedora Release Engineering
> <releng(a)fedoraproject.org&gt; - 2.1.7-2
>  - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
> 
> 
> 
>
	https://src.fedoraproject.org/rpms/apt/c/f4bac7efd3c251ffb64107bc2f522c1d...
> 
> --
> You received this message due to your preference settings at
>
https://apps.fedoraproject.org/notifications/sergiomb.id.fedoraproject.or...

[Jeff Law]

On Wed, 2020-07-29 at 14:13 +0100, sergio(a)serjux.com wrote:
>  Hello opencv [1] build also failed around LTO
>  What is your advise ? What is your advice? 
In general I want to have a very good
indicator the issue is LTO related before I
disable.  THe build you referenced doesn't have any good indicators that LTO is
the problem.

For ppc64le is that the build was done with p8, but there is one function
(__builtin_altivec_vadub) that requires p9.  This seems like a package bug at
first glance, not an LTO issue.  I would try a ppc64le test build with and
without LTO, my guess is both are going to fail with similar problems.

For s390 I would guess that it got aborted -- there's nothing useful in the
build.log.  So I'd try an LTO test build of that.

Jeff

[Vitaly Zaitsev]

On 29.07.2020 15:59, Jeff Law wrote:
>  In general I want to have a very good indicator the issue is LTO
> related before I
>  disable.  THe build you referenced doesn't have any good indicators that LTO is
>  the problem. 
My packages nheko and mtxclient are failed due to LTO. Can you check
them? Currently built with Clang, but I can try to switch to GCC.

https://koji.fedoraproject.org/koji/buildinfo?buildID=1558560
https://koji.fedoraproject.org/koji/buildinfo?buildID=1558793

-- 
Sincerely,
  Vitaly Zaitsev (vitaly(a)easycoding.org)

[Jeff Law]

On Thu, 2020-07-30 at 10:54 +0200, Vitaly Zaitsev via devel wrote:
>  On 29.07.2020 15:59, Jeff Law wrote:
>  > In general I want to have a very good indicator the issue is LTO related before I
>  > disable.  THe build you referenced doesn't have any good indicators that LTO is
>  > the problem.
>  
>  My packages nheko and mtxclient are failed due to LTO. Can you check
>  them? Currently built with Clang, but I can try to switch to GCC.
>  
>  https://koji.fedoraproject.org/koji/buildinfo?buildID=1558560
>  https://koji.fedoraproject.org/koji/buildinfo?buildID=1558793 
Umm, those builds
look fine -- I don't see any failures in those builds.

I would not generally recommend switching compilers to work around issues of any
kind. 

Jeff

[Vitaly Zaitsev]

On 31.07.2020 19:15, Jeff Law wrote:
>  Umm, those builds look fine -- I don't see any failures in those
> builds. 
Switching to GCC fixed these issues.

>  I would not generally recommend switching compilers to work around
> issues of any
>  kind.  
I used Clang only as a workaround to issue with another package, as it
was incompatible with GCC 10.

-- 
Sincerely,
  Vitaly Zaitsev (vitaly(a)easycoding.org)

[Michael J Gruber]

>  On Wed, 2020-07-29 at 14:13 +0100, sergio(a)serjux.com wrote:
>  In general I want to have a very good
>  indicator the issue is LTO related before I
>  disable.  THe build you referenced doesn't have any good indicators that LTO is
>  the problem.
>  
>  For ppc64le is that the build was done with p8, but there is one function
>  (__builtin_altivec_vadub) that requires p9.  This seems like a package bug at
>  first glance, not an LTO issue.  I would try a ppc64le test build with and
>  without LTO, my guess is both are going to fail with similar problems. 
I don't see p8 mentioned specifically in the opencv spec, but how would one build with
p9 (once the buildroot is OK again, gettext...)?

[Vascom]

Disable LTO
https://src.fedoraproject.org/rpms/redhat-rpm-config/c/5baaf4a99cc77572d3...

ср, 29 июл. 2020 г., 17:08 <sergio(a)serjux.com&gt;:

>  Hello opencv [1] build also failed around LTO
>  What is your advise ? What is your advice?
>
>  Thanks,
>
>  [1]
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=48054416
>
>
>  On 2020-07-27 23:46, notifications(a)fedoraproject.org wrote:
>  > Notification time stamped 2020-07-27 22:46:34 UTC
>  >
>  > From f4bac7efd3c251ffb64107bc2f522c1d3c829b5c Mon Sep 17 00:00:00 2001
>  > From: Jeff Law <law(a)redhat.com&gt;
>  > Date: Jul 27 2020 22:46:22 +0000
>  > Subject: Disable LTO for now
>  >
>  >
>  > ---
>  >
>  > diff --git a/apt.spec b/apt.spec
>  > index a555b62..282ddc8 100644
>  > --- a/apt.spec
>  > +++ b/apt.spec
>  > @@ -14,7 +14,7 @@
>  >
>  >  Name:           apt
>  >  Version:        2.1.7
>  > -Release:        2%{?dist}
>  > +Release:        3%{?dist}
>  >  Summary:        Command-line package manager for Debian packages
>  >
>  >  License:        GPLv2+
>  > @@ -166,6 +166,10 @@ to package management with APT.
>  >  %autosetup -p1
>  >
>  >  %build
>  > +# This package fails its testsuite when LTO is enabled.  It is not yet
>  > clear if
>  > +# this is an LTO issue or an issue with the package itself
>  > +%define _lto_cflags %{nil}
>  > +
>  >  %cmake -GNinja
>  >  %cmake_build
>  >
>  > @@ -308,6 +312,9 @@ exit 0
>  >  %doc %{_docdir}/%{name}-utils
>  >
>  >  %changelog
>  > +* Mon Jul 27 2020 Jeff law <law(a)redhat.com.com&gt; - 2.1.7-3
>  > +- Disable LTO for now
>  > +
>  >  * Mon Jul 27 2020 Fedora Release Engineering
>  > <releng(a)fedoraproject.org&gt; - 2.1.7-2
>  >  - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
>  >
>  >
>  >
>  >
>
> https://src.fedoraproject.org/rpms/apt/c/f4bac7efd3c251ffb64107bc2f522c1d...
>  >
>  > --
>  > You received this message due to your preference settings at
>  >
>  https://apps.fedoraproject.org/notifications/sergiomb.id.fedoraproject.or...
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct:
>  https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]
>