Bundled compiler conundrum

[Michael Cronenworth]

Hi,

Wine has soft-dependencies on two additional pieces of software to provide a
"full" 
experience.

* wine-gecko - Gecko web browser engine for Wine
* wine-mono - .NET for Wine

I package both for Wine. They're typically updated at most a couple times per year. 
Usually the updates bring with them problems that require major time to fix. A FTBFS 
for wine-gecko took about two years to fix, but that was an extreme case. Both 
packages use the MinGW (GCC-based) toolchain to compile and we're lucky enough to 
also carry that toolchain in Fedora. We may be the only distro to compile from 
source as other distros carry the binary that upstream provides.

The bi-weekly Wine update last week brought with it a minor version (5.0.0->5.1.0) 
wine-mono update. The update itself is not minor. The tarball is now bundling a 
Clang LLVM-based MinGW toolchain in binary form that is also required to compile the 
package. My first effort at stripping it out to use our Fedora MinGW toolchain 
doesn't work with the Clang style CFLAGS they have switched to. Before I spend more 
time de-bundling:

I know bundled libraries are allowed, but what about bundled compilers?

I have not talked to upstream (Wine) on this change yet. I don't believe upstream 
Mono, that Wine bases this code on, requires Clang.

Thanks,
Michael

[Omair Majid]

Michael Cronenworth <mike(a)cchtml.com&gt; writes:

>  The bi-weekly Wine update last week brought with it a minor version
> (5.0.0->5.1.0)
>  wine-mono update. The update itself is not minor. The tarball is now bundling a
>  Clang LLVM-based MinGW toolchain in binary form that is also required to compile the
>  package. My first effort at stripping it out to use our Fedora MinGW toolchain
>  doesn't work with the Clang style CFLAGS they have switched to. Before I spend more
>  time de-bundling:
>
>  I know bundled libraries are allowed, but what about bundled compilers? 
If I am readying your question correctly, it's not just that wine
bundles compilers and libraries, it's that wine bundles pre-built
binaries of compilers and libraries.

As I understand it, bundling and use of pre-built binaries are two
different issues.

Bundling is allowed.

My reading of the packaging guidelines says using pre-bulit binaries is
not allowed at all:

"""
When you encounter prebuilt binaries in a package you MUST:

 -  Remove all pre-built program binaries and program libraries in %prep
    prior to the building of the package. Examples include, but are not
    limited to, *.class, *.dll, *.DS_Store, *.exe, *.jar, *.o, *.pyc,
    *.pyo, *.egg, *.so, *.swf files.
"""

And

"""
Some software (usually related to compilers or cross-compiler
environments) cannot be built without the use of a previous toolchain or
development environment (open source). If you have a package which meets
this criteria, contact the Fedora Packaging Committee for approval.
Please note that this exception, if granted, is limited to only the
initial build of the package. You may bootstrap this build with a
"bootstrap" pre-built binary, but after this is complete, you must
immediately increment Release, drop the "bootstrap" pre-built binary,
and build completely from source. Bootstrapped packages containing
pre-built "bootstrap" binaries must not be pushed as release packages or
updates under any circumstances.
"""

https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-pac...

Thanks,
Omair

--
PGP Key: B157A9F0 (http://pgp.mit.edu/)
Fingerprint = 9DB5 2F0B FD3E C239 E108  E7BD DF99 7AF8 B157 A9F0

[Tom Stellard]

On 06/25/2020 08:01 PM, Michael Cronenworth wrote:
>  Hi,
>  
>  Wine has soft-dependencies on two additional pieces of software to provide a
> "full" experience.
>  
>  * wine-gecko - Gecko web browser engine for Wine
>  * wine-mono - .NET for Wine
>  
>  I package both for Wine. They're typically updated at most a couple times per year.
> Usually the updates bring with them problems that require major time to fix. A FTBFS for
> wine-gecko took about two years to fix, but that was an extreme case. Both packages use
> the MinGW (GCC-based) toolchain to compile and we're lucky enough to also carry that
> toolchain in Fedora. We may be the only distro to compile from source as other distros
> carry the binary that upstream provides.
>  
>  The bi-weekly Wine update last week brought with it a minor version (5.0.0->5.1.0)
> wine-mono update. The update itself is not minor. The tarball is now bundling a Clang
> LLVM-based MinGW toolchain in binary form that is also required to compile the package. My
> first effort at stripping it out to use our Fedora MinGW toolchain doesn't work with
> the Clang style CFLAGS they have switched to. Before I spend more time de-bundling:
>   
Are you tying to build with mingw-gcc?  What errors are you getting?

-Tom

>  I know bundled libraries are allowed, but what about bundled
> compilers?
>  
>  I have not talked to upstream (Wine) on this change yet. I don't believe upstream
> Mono, that Wine bases this code on, requires Clang.
>  
>  Thanks,
>  Michael
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]

[Michael Cronenworth]

On 6/25/20 11:45 PM, Tom Stellard wrote:
>  Are you tying to build with mingw-gcc?  What errors are you getting?
Yes, mingw-gcc, as we do not ship the Clang based MinGW toolchain in Fedora.

Here's a sample:

cc1plus: error: unrecognized command line option 
'-Wno-implicit-int-float-conversion' [-Werror]
cc1plus: error: unrecognized command line option '-Wno-parentheses-equality'
[-Werror]
cc1plus: error: unrecognized command line option '-Wno-undefined-var-template'
[-Werror]
cc1plus: error: unrecognized command line option '-Wno-deprecated-register'
[-Werror]
cc1plus: error: unrecognized command line option 
'-Wno-inconsistent-missing-override' [-Werror]
cc1plus: error: unrecognized command line option '-Wno-undefined-inline'
[-Werror]
cc1plus: error: unrecognized command line option '-Wno-ignored-pragma-optimize' 
[-Werror]
cc1plus: error: unrecognized command line option '-Wno-inline-new-delete'
[-Werror]

[Tom Stellard]

On 06/26/2020 10:01 AM, Michael Cronenworth wrote:
>  On 6/25/20 11:45 PM, Tom Stellard wrote:
> > Are you tying to build with mingw-gcc?  What errors are you getting?
>  
>  Yes, mingw-gcc, as we do not ship the Clang based MinGW toolchain in Fedora.
>  
>  Here's a sample:
>  
>  cc1plus: error: unrecognized command line option
> '-Wno-implicit-int-float-conversion' [-Werror]
>  cc1plus: error: unrecognized command line option '-Wno-parentheses-equality'
> [-Werror]
>  cc1plus: error: unrecognized command line option '-Wno-undefined-var-template'
> [-Werror]
>  cc1plus: error: unrecognized command line option '-Wno-deprecated-register'
> [-Werror]
>  cc1plus: error: unrecognized command line option
> '-Wno-inconsistent-missing-override' [-Werror]
>  cc1plus: error: unrecognized command line option '-Wno-undefined-inline'
> [-Werror]
>  cc1plus: error: unrecognized command line option '-Wno-ignored-pragma-optimize'
> [-Werror]
>  cc1plus: error: unrecognized command line option '-Wno-inline-new-delete'
> [-Werror]
>  
>   
How different is the clang mingw toolchain shipped with wine-mono than the
vanilla clang we have in Fedora?  Looking at the wine-mono sources, it
looks like their mingw toolchain might just be a wrapper around a standard
build of clang, but I'm not really all that familiar with how mingw works.

-Tom

[Jonathan Wakely]

On 26/06/20 12:01 -0500, Michael Cronenworth wrote:
> On 6/25/20 11:45 PM, Tom Stellard wrote:
> >Are you tying to build with mingw-gcc?  What errors are you getting?
>
> Yes, mingw-gcc, as we do not ship the Clang based MinGW toolchain in Fedora.
>
> Here's a sample:
>
> cc1plus: error: unrecognized command line option 
> '-Wno-implicit-int-float-conversion' [-Werror]
> cc1plus: error: unrecognized command line option '-Wno-parentheses-equality'
> [-Werror]
> cc1plus: error: unrecognized command line option '-Wno-undefined-var-template'
> [-Werror]
> cc1plus: error: unrecognized command line option '-Wno-deprecated-register'
> [-Werror]
> cc1plus: error: unrecognized command line option 
> '-Wno-inconsistent-missing-override' [-Werror]
> cc1plus: error: unrecognized command line option '-Wno-undefined-inline'
> [-Werror]
> cc1plus: error: unrecognized command line option 
> '-Wno-ignored-pragma-optimize' [-Werror]
> cc1plus: error: unrecognized command line option '-Wno-inline-new-delete'
> [-Werror] 
GCC does not complain about unrecognized -Wno-xxx options unless
another warning or error has ben issued.

So these are not the problem.

You seem to be using -Werror, which probably means that some other
(possibly innocuous) warning caused an error, and because compilation
had already failed, GCC decided to *also* tell you about the
unrecognized -Wno-xxx options.

Fix your real problem, and the -Wno-xxx warnings will go away.

Stop using -Werror and they'll just be warnings anyway.

[Vitaly Zaitsev]

On 26.06.2020 19:01, Michael Cronenworth wrote:
>  cc1plus: error: unrecognized command line option
>  '-Wno-implicit-int-float-conversion' [-Werror] 
Just remove -Werror flag.

-- 
Sincerely,
  Vitaly Zaitsev (vitaly(a)easycoding.org)

[Vitaly Zaitsev]

On 26.06.2020 05:01, Michael Cronenworth wrote:
>  I know bundled libraries are allowed, but what about bundled
> compilers? 
Pre-compiled binaries are strictly forbidden by Fedora guidelines. All
binaries must be built on Fedora infra.

If you have cyclic dependencies, you should use bootstrapping[1].

[1]:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bootstrapping

-- 
Sincerely,
  Vitaly Zaitsev (vitaly(a)easycoding.org)